Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve Windows native build instructions #14973

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@murrayn
Copy link
Contributor

commented Dec 16, 2018

The current instructions assume usage of PowerShell; running in a Command Prompt results in a syntax error. Proposed change works with both Command Prompt and PowerShell.

Also a few other minor formatting changes.

@fanquake fanquake added the Docs label Dec 16, 2018

@fanquake fanquake requested a review from ken2812221 Dec 17, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

@sipsorcery Can you review?

@ken2812221
Copy link
Member

left a comment

Concept ACK

build_msvc/README.md Outdated
berkeleydb:x64-windows-static `
secp256k1:x64-windows-static `
leveldb:x64-windows-static
PS >.\vcpkg install boost:x64-windows-static libevent:x64-windows-static openssl:x64-windows-static zeromq:x64-windows-static berkeleydb:x64-windows-static secp256k1:x64-windows-static leveldb:x64-windows-static

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Dec 17, 2018

Member

Could use .\vcpkg install --triplet x64-windows-static boost-filesystem boost-signals2 boost-test libevent openssl zeromq berkeleydb secp256k1 leveldb instead. Don't have to install all boost dependencies.

This comment has been minimized.

Copy link
@sipsorcery

sipsorcery Dec 17, 2018

Contributor

+1 for switching to @ken2812221's vcpkg command (see note below).

@fanquake fanquake changed the title Improve Windows native build instructions doc: Improve Windows native build instructions Dec 17, 2018

@sipsorcery

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

tACK.

@ken2812221 I ran an appveyor build with each of the twovcpkg commands below and both dragged in the exact same 80 packages, 70 of which were boost.

Your version is an improvement as it's shorter and I guess if the Boost dependency chain ever changes it could end up pulling in less packages.

vcpkg install --triplet x64-windows-static boost-filesystem boost-signals2 boost-test libevent openssl zeromq berkeleydb secp256k1 leveldb

vcpkg install boost:x64-windows-static libevent:x64-windows-static openssl:x64-windows-static zeromq:x64-windows-static berkeleydb:x64-windows-static secp256k1:x64-windows-static leveldb:x64-windows-static

@murrayn murrayn force-pushed the murrayn:win_build_doc branch to 5237850 Dec 18, 2018

@murrayn

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

I've incorporated @ken2812221 's suggestion.

@fanquake

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

utACK 5237850

@sipsorcery

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

tACK 5237850.

@laanwj laanwj merged commit 5237850 into bitcoin:master Dec 28, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

laanwj added a commit that referenced this pull request Dec 28, 2018

Merge #14973: doc: Improve Windows native build instructions
5237850 Modify build instructions to work with Command Prompt as well as PowerShell; other minor changes (Murray Nesbitt)

Pull request description:

  The current instructions assume usage of `PowerShell`; running in a `Command Prompt` results in a syntax error. Proposed change works with both `Command Prompt` and `PowerShell`.

  Also a few other minor formatting changes.

Tree-SHA512: 5f8782d8706c99d7680db01e560ccd823c8442f0f19b65ae54183a810994418d168527bbf3430fa5d88b3a55264e66ef08fe1f5949cce810b0a103a6b55ea363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.