Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Refactoring with QString::toNSString() #14975

Merged

Conversation

Projects
None yet
7 participants
@hebasto
Copy link
Member

commented Dec 16, 2018

This PR makes MacNotificationHandler::showNotification() cleaner and more readable.
The used QString::toNSString() function was introduced in Qt 5.2 which is minimum version now (#14725).

The behavior of MacNotificationHandler::showNotification() has not been changed.

cc: @jonasschnelli

Refactoring with QString::toNSString
The behavior of MacNotificationHandler::showNotification() has not been
changed.
@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

nice cleanup utACK 4d454dc

@promag

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Tested ACK 4d454dc on macOS 10.14.1.

@fanquake fanquake requested a review from jonasschnelli Dec 17, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

Gitian builds for commit 3424171 (master):

Gitian builds for commit e99c68ced48a1480d21aaebc63886d9a6b28012d (master and this pull):

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

Hmm... How is it possible that changes in macOS-related Objective-C code can alter Linux and Windows builds (as hashes are different)?

@jonasschnelli
Copy link
Member

left a comment

Yes. Nice cleanup. The weak linking is no longer required since we don't support macOS older then 10.8 (where the Notification Center was introduced).

utACK 4d454dc

@jonasschnelli jonasschnelli merged commit 4d454dc into bitcoin:master Dec 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Dec 18, 2018

Merge #14975: qt: Refactoring with QString::toNSString()
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5

@hebasto hebasto deleted the hebasto:20181216-macos-shownotification-refactor branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.