Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Refactoring with QString::toNSString() #14975

Merged

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Dec 16, 2018

This PR makes MacNotificationHandler::showNotification() cleaner and more readable.
The used QString::toNSString() function was introduced in Qt 5.2 which is minimum version now (#14725).

The behavior of MacNotificationHandler::showNotification() has not been changed.

cc: @jonasschnelli

The behavior of MacNotificationHandler::showNotification() has not been
changed.
@laanwj
Copy link
Member

@laanwj laanwj commented Dec 17, 2018

nice cleanup utACK 4d454dc

@promag
Copy link
Member

@promag promag commented Dec 17, 2018

Tested ACK 4d454dc on macOS 10.14.1.

@fanquake fanquake requested a review from jonasschnelli Dec 17, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Dec 17, 2018

Gitian builds for commit 3424171 (master):

Gitian builds for commit e99c68ced48a1480d21aaebc63886d9a6b28012d (master and this pull):

@hebasto
Copy link
Member Author

@hebasto hebasto commented Dec 18, 2018

Hmm... How is it possible that changes in macOS-related Objective-C code can alter Linux and Windows builds (as hashes are different)?

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Yes. Nice cleanup. The weak linking is no longer required since we don't support macOS older then 10.8 (where the Notification Center was introduced).

utACK 4d454dc

@jonasschnelli jonasschnelli merged commit 4d454dc into bitcoin:master Dec 18, 2018
2 checks passed
jonasschnelli added a commit that referenced this issue Dec 18, 2018
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
@hebasto hebasto deleted the 20181216-macos-shownotification-refactor branch Dec 18, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 26, 2020
Summary:
4d454dcb6 Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

---

Backport of Core [[bitcoin/bitcoin#14975 | PR14975]]

Test Plan:
  ninja all check check-functional

I don't have macOS to run the suite sadly

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8132
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 5, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 8, 2021
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants