Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Clarifying RPC getrawtransaction's time help text #14981

Merged

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Dec 17, 2018

#12339

The time and blocktime entries have the same value so they should have the same help text as well

@benthecarman benthecarman force-pushed the getrawtransaction_help_text_fix branch from 4504b58 to 845d14c Dec 17, 2018
@promag
Copy link
Member

@promag promag commented Dec 17, 2018

Concept ACK.

You have to rebase with master.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 17, 2018

utACK 845d14cff70c5da741952c2395adbead263516a5

@promag
Copy link
Member

@promag promag commented Dec 17, 2018

utACK 845d14c.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Dec 17, 2018
@promag
Copy link
Member

@promag promag commented Dec 17, 2018

Invalid push? Reset to 845d14c?

@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Dec 17, 2018

Invalid push? Reset to 845d14c?

Yeah my bad

@benthecarman benthecarman force-pushed the getrawtransaction_help_text_fix branch from 25e34fd to 845d14c Dec 17, 2018
@benthecarman benthecarman force-pushed the getrawtransaction_help_text_fix branch from 845d14c to 84104c7 Dec 17, 2018
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 17, 2018

No need to rebase. Could just force push the already reviewed commit?

@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Dec 17, 2018

No need to rebase. Could just force push the already reviewed commit?

I thought the same thing but @promag asked for a rebase

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 17, 2018

We had issues with travis earlier today, but it is possible to just reset a travis run without a rebase or otherwise touching the commit.

@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Dec 17, 2018

I did not know that, but good to know

@benthecarman benthecarman changed the title Clarifying RPC getrawtransaction's time help text rpc: Clarifying RPC getrawtransaction's time help text Dec 18, 2018
@fanquake
Copy link
Member

@fanquake fanquake commented Dec 28, 2018

utACK 84104c7

@MarcoFalke MarcoFalke merged commit 84104c7 into bitcoin:master Dec 28, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Dec 28, 2018
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  #12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
@benthecarman benthecarman deleted the getrawtransaction_help_text_fix branch Dec 29, 2018
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 2, 2020
Summary:
d94d34f05f4ae3efa07de409489d68bbcc216346 doc: update developer notes wrt unix epoch time (Jon Atack)
e2f32cb5c5c7f2b1d1fc7003587b6573fb59526a qa: unify unix epoch time descriptions (Jon Atack)

Pull request description:

  Closes #17613.

  Updated call sites: mocktime, getblockheader, getblock, pruneblockchain,
  getchaintxstats, getblocktemplate, setmocktime, getpeerinfo, setban,
  getnodeaddresses, getrawtransaction, importmulti, listtransactions,
  listsinceblock, gettransaction, getwalletinfo, getaddressinfo

  Commands for testing manually:
  ```
  bitcoind -help-debug | grep -A1 mocktime
  bitcoin-cli help getblockheader
  bitcoin-cli help getblock
  bitcoin-cli help pruneblockchain
  bitcoin-cli help getchaintxstats
  bitcoin-cli help getblocktemplate
  bitcoin-cli help setmocktime
  bitcoin-cli help getpeerinfo
  bitcoin-cli help setban
  bitcoin-cli help getnodeaddresses
  bitcoin-cli help getrawtransaction
  bitcoin-cli help importmulti
  bitcoin-cli help listtransactions
  bitcoin-cli help listsinceblock
  bitcoin-cli help gettransaction
  bitcoin-cli help getwalletinfo
  bitcoin-cli help getaddressinfo
  ```

---

Backport of Core [[bitcoin/bitcoin#17617 | PR17617]] and [[bitcoin/bitcoin#14981 | PR14981]]

~~Note: used the newly introduced constant in two instances not covered in the backport, specifically in getrawtransaction and getblocktemplate~~

Test Plan:
  ninja all check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7721
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 24, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 24, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 25, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 25, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 26, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 28, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
84104c7 clarifying getrawtransaction[time] get help text (Ben Carman)

Pull request description:

  bitcoin#12339

  The `time` and `blocktime` entries have the same value so they should have the same help text as well

Tree-SHA512: 1e9a94678eec8501c761f16bf3d8e269d68620596d1fdd31a32989a1b53be5a8097ece8bfabe99979e658dec82237e37d8194ae2acd7c1deef7501ee701667fb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants