Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add getrpcinfo command #14982

Merged
merged 5 commits into from Jan 14, 2019
Merged

rpc: Add getrpcinfo command #14982

merged 5 commits into from Jan 14, 2019

Conversation

@promag
Copy link
Member

@promag promag commented Dec 17, 2018

The new getrpcinfo command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted).

src/rpc/server.cpp Outdated Show resolved Hide resolved
src/rpc/server.cpp Outdated Show resolved Hide resolved
@laanwj
Copy link
Member

@laanwj laanwj commented Dec 17, 2018

Concept ACK

src/rpc/server.cpp Outdated Show resolved Hide resolved
src/rpc/server.cpp Outdated Show resolved Hide resolved
src/rpc/server.cpp Outdated Show resolved Hide resolved
src/rpc/server.cpp Outdated Show resolved Hide resolved
@promag
Copy link
Member Author

@promag promag commented Dec 18, 2018

@Empact @practicalswift I guess you concept ACK?

@ch4ot1c
Copy link
Contributor

@ch4ot1c ch4ot1c commented Dec 18, 2018

Concept Ack.

Does uptime belong in the response? Should it be a separate rpc_uptime, measured instead from StartRPC / the Started signal?:

StartRPC();

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Dec 19, 2018

Concept ACK.

  • What about showing active commands (things like rescanblockchain and scantxoutset)?

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Dec 21, 2018

Concept ACK

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Dec 21, 2018

concept ACK . could it add things like port it's listening to?

@promag
Copy link
Member Author

@promag promag commented Dec 21, 2018

I guess you have to know that to call this RPC?

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Dec 21, 2018

@promag the computer knows this, yes ;P

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 2, 2019

So I'd say if everyone is Concept ACK, I think it makes sense to fix the nits, utACK and merge this and add further ideas in later PRs.

@promag promag force-pushed the 2018-12-getrpcinfo branch from 9d4d3ab to a0ac154 Jan 2, 2019
@promag
Copy link
Member Author

@promag promag commented Jan 2, 2019

@laanwj updated.

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 9, 2019

utACK a0ac154

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Jan 13, 2019

tested ACK 251a91c

It currently mildly useful and I can't follow the discussion why uptime is gone. But this is a great starting point for a general RPC state report.

@laanwj laanwj merged commit a0ac154 into bitcoin:master Jan 14, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 14, 2019
a0ac154 doc: Add getrpcinfo release notes (João Barbosa)
251a91c qa: Add tests for getrpcinfo (João Barbosa)
d0730f5 rpc: Add getrpcinfo command (João Barbosa)
068a8fc rpc: Track active commands (João Barbosa)
bf43832 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

  The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

  This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted).

Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
@promag promag deleted the 2018-12-getrpcinfo branch Jan 14, 2019
pravblockc added a commit to pravblockc/dash that referenced this issue Aug 10, 2021
a0ac154 doc: Add getrpcinfo release notes (João Barbosa)
251a91c qa: Add tests for getrpcinfo (João Barbosa)
d0730f5 rpc: Add getrpcinfo command (João Barbosa)
068a8fc rpc: Track active commands (João Barbosa)
bf43832 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

  The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

  This can be particular useful to coordinate concurrent functional tests (see bitcoin#14958 from where this was extracted).

Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
pravblockc added a commit to pravblockc/dash that referenced this issue Aug 10, 2021
a0ac154 doc: Add getrpcinfo release notes (João Barbosa)
251a91c qa: Add tests for getrpcinfo (João Barbosa)
d0730f5 rpc: Add getrpcinfo command (João Barbosa)
068a8fc rpc: Track active commands (João Barbosa)
bf43832 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

  The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

  This can be particular useful to coordinate concurrent functional tests (see bitcoin#14958 from where this was extracted).

Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
pravblockc added a commit to pravblockc/dash that referenced this issue Aug 14, 2021
a0ac154 doc: Add getrpcinfo release notes (João Barbosa)
251a91c qa: Add tests for getrpcinfo (João Barbosa)
d0730f5 rpc: Add getrpcinfo command (João Barbosa)
068a8fc rpc: Track active commands (João Barbosa)
bf43832 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

  The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

  This can be particular useful to coordinate concurrent functional tests (see bitcoin#14958 from where this was extracted).

Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants