Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: add names to Travis jobs #15020

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
8 participants
@gkrizek
Copy link
Contributor

commented Dec 21, 2018

This adds the name field to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing.

Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved .travis.yml Outdated

@scravy scravy referenced this pull request Dec 21, 2018

Merged

Set names for jobs #393

@scravy

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

@fanquake fanquake added the Tests label Dec 21, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 24, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14998 ([WIP] Run CI against ubuntu 14.04 by Empact)
  • #14505 (Add linter to make sure single parameter constructors are marked explicit (C++11) by default by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

Concept ACK

@gkrizek gkrizek force-pushed the gkrizek:travis-job-names branch to 30922a7 Dec 26, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 26, 2018

As previously commented, when you add a name to your jobs the Travis UI removes the environment variables from the build when in the list view. (They still show up when you view an individual build's page). I think having a build name is more valuable in the list view than the variables. We can always add some sort of 'tag' to the job name if we feel that's needed.

@fanquake

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

Here's the current Travis setup vs this PR:
Current:
current
#15020 (30922a7):
build names

If anything, I think we could add more build related information to the "name", if we go down that route.

@fanquake fanquake requested a review from MarcoFalke Dec 31, 2018

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

Here's an example where a new "disable bip 70" build was added - I challenge you to quickly identify which build it is: https://travis-ci.org/bitcoin/bitcoin/builds/473735618?utm_source=github_status&utm_medium=notification #15063

It could be helpful to describe the build more fully, e.g. "no depends, only system libs, sanitizers: thread (TSan)" is relevant IMO. Also possibly: GOAL, osx version.

@gkrizek gkrizek force-pushed the gkrizek:travis-job-names branch from 30922a7 Dec 31, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018

@Empact That's why I thought this PR could be helpful. Same for someone new looking at the project. Very hard to tell what's going on in the current state.

I just pushed a commit that adds more details to the job names as it seems like more are in agreement that it would be helpful.

Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved .travis.yml Outdated

@gkrizek gkrizek force-pushed the gkrizek:travis-job-names branch Jan 3, 2019

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

@fanquake Thanks for the review! I've pushed a commit with your changes added.

@fanquake

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

ACK 5af7d0b. I think this is ok now.

travis named jobs

@scravy @Empact thoughts?

Show resolved Hide resolved .travis.yml Outdated
@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

Concept ACK

Add names to Travis jobs
This also removes job name comments from .travis.yml because they are no longer necessary

@gkrizek gkrizek force-pushed the gkrizek:travis-job-names branch to 1db71d4 Jan 3, 2019

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 3, 2019

Merge bitcoin#15020: Build: add names to Travis jobs
1db71d4 Add names to Travis jobs (Graham Krizek)

Pull request description:

  This adds the `name` field to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing.

Tree-SHA512: d65841bab0a80d098a46a4bb54af2f9a93db7abca93b848aa00d25dcf4cd74323371c7c0b78b4dbf390b197e7ba32262a91631e201fc505f834021753f700b28

@MarcoFalke MarcoFalke merged commit 1db71d4 into bitcoin:master Jan 3, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gkrizek gkrizek deleted the gkrizek:travis-job-names branch Jan 3, 2019

@jnewbery

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Great! I've been wanting this for a long time. utACK 1db71d4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.