Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Upgrade Travis OS to Xenial #15022

Merged
merged 3 commits into from Dec 29, 2018

Conversation

Projects
None yet
5 participants
@gkrizek
Copy link
Contributor

commented Dec 21, 2018

Update base Travis OS to xenial from trusty.

Link to Travis Docs for Xenial: https://docs.travis-ci.com/user/reference/xenial/

As noted in the documentation, Docker version is also updated from 17.06 to 18.06

Also includes:
- If running Bitcoin config with LSan sanitizer, Allow ptrace in Docker run command
- Increase timeout of feature_assumevalid test to fix flaky tests

@gkrizek gkrizek closed this Dec 21, 2018

@gkrizek gkrizek changed the title Test os update Build: Upgrade Travis OS to Xenail Dec 21, 2018

@gkrizek gkrizek reopened this Dec 21, 2018

@gkrizek gkrizek changed the title Build: Upgrade Travis OS to Xenail Build: Upgrade Travis OS to Xenial Dec 21, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

This also updates the compilers and build toolchain, but that shouldn't matter on the host because everything is ran inside of Docker, correct?

clang and llvm 7
cmake 3.12.4
gcc 5.4.0
ccache 3.2.4

https://docs.travis-ci.com/user/reference/xenial/#compilers-and-build-toolchain

@gkrizek gkrizek force-pushed the gkrizek:xenial branch 2 times, most recently Dec 22, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

I can't find a legitimate reason by looking through the Docker changelogs or documentation, but when running tests with LSan sanitizer, Docker requires the --cap-add SYS_PTRACE flag set in v18.06. This didn't seem to be a problem with v17.06

See relevant issue here:
google/sanitizers#764

@gkrizek gkrizek closed this Dec 24, 2018

@gkrizek gkrizek reopened this Dec 24, 2018

@meshcollider

This comment has been minimized.

Copy link
Member

commented Dec 24, 2018

@gkrizek please stop opening and closing this :)

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

Sorry, @meshcollider. The first time was an accident then the second was to trigger a new CI run. One of the tests seems flaky, but I’ll test that in my fork. :)

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

@gkrizek To trigger a new build, you can set up an account at travis-ci.org and control the builds under: http://travis-ci.org/gkrizek/bitcoin

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 26, 2018

Thanks @Empact. I was doing that earlier and it was passing in my fork. That's why I thought this was good to go, but now a test is failing so I need to investigate that more.

@gkrizek gkrizek force-pushed the gkrizek:xenial branch Dec 26, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 26, 2018

This is complete and ready for review. I've fixed some issues with tests and builds are passing consistently.

Show resolved Hide resolved .travis/test_04_install.sh Outdated
@fanquake

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

This should probably be broken into two or three commits. i.e the Travis change (with/without the sanitizer change) and then the test timeout change in a separate commit.

gkrizek added some commits Dec 28, 2018

Update Travis base OS to Xenial
Updating the base OS used in Travis to Xenial from Trusty. This also updates Docker to 18.06 instead of 17.06 in CI.

@gkrizek gkrizek force-pushed the gkrizek:xenial branch to b6f0db6 Dec 28, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

@fanquake Updated. I split it into 3 commits. Thanks!

@fanquake fanquake requested a review from MarcoFalke Dec 29, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

utACK b6f0db6. We don't use any features from the travis image other than docker, so changing it shouldn't matter.

@fanquake

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

Thanks @MarcoFalke. If anything we might get slightly faster build times.

utACK b6f0db6 - appveyor is the failure.

@fanquake fanquake changed the title Build: Upgrade Travis OS to Xenial tests: Upgrade Travis OS to Xenial Dec 29, 2018

@gkrizek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

It looks like this ran about 5 minutes faster than another PR I have open. So I haven’t done testing to compare speeds, but it does seem faster.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Dec 29, 2018

Merge bitcoin#15022: tests: Upgrade Travis OS to Xenial
b6f0db6 Increase timeout of featuer_assumevalid test to fix flaky tests (Graham Krizek)
aa9aca8 If tests are ran with (ASan + LSan), Docker needs access to ptrace (Graham Krizek)
a3b8b43 Update Travis base OS to Xenial (Graham Krizek)

Pull request description:

  Update base Travis OS to `xenial` from `trusty`.

  Link to Travis Docs for Xenial: https://docs.travis-ci.com/user/reference/xenial/

  As noted in the documentation, Docker version is also updated from `17.06` to `18.06`

  Also includes:
      - If running Bitcoin config with LSan sanitizer, Allow ptrace in Docker run command
      - Increase timeout of feature_assumevalid test to fix flaky tests

Tree-SHA512: baf2eda0cbb9990c43c76de1aebc8dd4a3f540323ac1fe2e164ac3bcf1fe3afa3e5b026bfeb5d650dae09a6854695d5744c1130c2fa82ece86c6835ba152f68d
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

Oh nice. Thanks for the speedup

@MarcoFalke MarcoFalke merged commit b6f0db6 into bitcoin:master Dec 29, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gkrizek gkrizek deleted the gkrizek:xenial branch Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.