Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Restore RPC Console to non-wallet tray icon menu #15023

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@luke-jr
Copy link
Member

commented Dec 21, 2018

#14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu.

#14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu.

This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had.

@promag

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Maybe also split like window menu?

@luke-jr

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

Dunno, that might be a bit extreme for merely a systray menu.

@promag

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Are there constraints/guidelines regarding systray menu?

@fanquake fanquake added the GUI label Dec 22, 2018

@hebasto

This comment has been minimized.

Copy link
Member

commented Dec 22, 2018

Are there constraints/guidelines regarding systray menu?

Dock Menus (by Apple) could be applicable, IMO.

UPDATE:
Notes from the XDevConf meeting:

Provide a menu like the OS X dock in the taskbar

@promag

This comment has been minimized.

Copy link
Member

commented Dec 22, 2018

Dock menu items should be available elsewhere in the app, too

This.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.