Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarifying testing instructions #15127

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Jan 8, 2019

This statement confused me on my first time reading through. Hopefully, this addition will help someone else on their first time.

@fanquake fanquake added the Docs label Jan 8, 2019
@sipa
Copy link
Member

@sipa sipa commented Jan 8, 2019

Is this needed? I never use those options

@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Jan 8, 2019

Is this needed? I never use those options

If that's true it might be better to change it to say something like "Be sure not to disable wallet, utils, and daemon, the default is recommended."

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 8, 2019

If the sentence is confusing I'd rather we just remove it. I don't think we need to add explicit documentation for options that are enabled by default.

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 8, 2019

Also tend to NACK. The tests are built by default, on purpose. It is a matter of following the build steps for whatever platform, no need to duplicate the configure command-line here.

@benthecarman benthecarman force-pushed the docs-clarifying-test-notes branch from 51894d8 to 2fbf2ca Jan 8, 2019
@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Jan 8, 2019

Changed it so it now gives a link to build instructions instead

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Jan 8, 2019

"Before tests can be run locally, your system must be built." isn't correct. You need to build bitcoind for your system (eg linux, macos, etc), not build your system.

ACK adding a reference to the build instructions.

@benthecarman benthecarman force-pushed the docs-clarifying-test-notes branch 2 times, most recently from 70e3328 to 127e37e Jan 8, 2019
@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Jan 8, 2019

ACK 127e37e7fcd426c990a6e4c49af9d1c35e76d384

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 8, 2019

utACK 127e37e

test/README.md Outdated Show resolved Hide resolved
@benthecarman benthecarman force-pushed the docs-clarifying-test-notes branch from 127e37e to ef5ebc6 Jan 9, 2019
@jnewbery
Copy link
Member

@jnewbery jnewbery commented Jan 9, 2019

ACK ef5ebc6

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 9, 2019

utACK ef5ebc6

@MarcoFalke MarcoFalke merged commit ef5ebc6 into bitcoin:master Jan 9, 2019
1 of 2 checks passed
MarcoFalke added a commit that referenced this issue Jan 9, 2019
ef5ebc6 docs: Clarifying testing instructions (benthecarman)

Pull request description:

  This statement confused me on my first time reading through.  Hopefully, this addition will help someone else on their first time.

Tree-SHA512: 17f421275adb7586eca954910269d29fcd3bacc42fab4bc2e01110f9e13ca6f8c1ca178246f7192e1131f14ced7f7dc0b57e7aec324898807c1813a2ebc513de
@benthecarman benthecarman deleted the docs-clarifying-test-notes branch Feb 8, 2019
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
ef5ebc6 docs: Clarifying testing instructions (benthecarman)

Pull request description:

  This statement confused me on my first time reading through.  Hopefully, this addition will help someone else on their first time.

Tree-SHA512: 17f421275adb7586eca954910269d29fcd3bacc42fab4bc2e01110f9e13ca6f8c1ca178246f7192e1131f14ced7f7dc0b57e7aec324898807c1813a2ebc513de
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
ef5ebc6 docs: Clarifying testing instructions (benthecarman)

Pull request description:

  This statement confused me on my first time reading through.  Hopefully, this addition will help someone else on their first time.

Tree-SHA512: 17f421275adb7586eca954910269d29fcd3bacc42fab4bc2e01110f9e13ca6f8c1ca178246f7192e1131f14ced7f7dc0b57e7aec324898807c1813a2ebc513de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants