Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Add Open Wallet menu #15153

Merged
merged 8 commits into from Feb 12, 2019
Merged

gui: Add Open Wallet menu #15153

merged 8 commits into from Feb 12, 2019

Conversation

@promag
Copy link
Member

@promag promag commented Jan 12, 2019

The Open Wallet menu has all the available wallets currently not loaded. The list of the available wallets comes from listWalletDir.

In the future the menu can be replaced by a custom dialog.

screenshot 2019-01-12 at 12 17 02

@fanquake fanquake added the GUI label Jan 12, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 12, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15204 (gui: Add Open External Wallet action by promag)
  • #15202 (gui: Add Close All Wallets action by promag)
  • #15195 (gui: Add Close Wallet action by promag)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@promag promag force-pushed the 2019-01-openwallet branch 3 times, most recently from 57850e6 to fa82113 Jan 12, 2019
@hebasto
Copy link
Member

@hebasto hebasto commented Jan 13, 2019

Concept ACK.

@promag promag force-pushed the 2019-01-openwallet branch 2 times, most recently from 4a39506 to cc906b3 Jan 14, 2019
src/qt/walletcontroller.cpp Outdated Show resolved Hide resolved
src/qt/walletcontroller.cpp Outdated Show resolved Hide resolved
src/qt/walletcontroller.cpp Outdated Show resolved Hide resolved
src/qt/walletcontroller.cpp Outdated Show resolved Hide resolved
@promag promag force-pushed the 2019-01-openwallet branch from cc906b3 to f9bea23 Jan 14, 2019
@promag promag force-pushed the 2019-01-openwallet branch from 4daa5c5 to 668499d Jan 14, 2019
@promag promag force-pushed the 2019-01-openwallet branch 2 times, most recently from b774219 to 4dac472 Jan 15, 2019
@promag promag force-pushed the 2019-01-openwallet branch from 4dac472 to 09780df Jan 15, 2019
@Sjors
Copy link
Member

@Sjors Sjors commented Jan 17, 2019

Concept ACK. Code looks good at first glance; will review once upstream is merged.

@promag promag force-pushed the 2019-01-openwallet branch from 09780df to 014f92a Jan 17, 2019
@promag promag force-pushed the 2019-01-openwallet branch 3 times, most recently from 3617f9d to e61178a Jan 18, 2019
@promag promag force-pushed the 2019-01-openwallet branch from e61178a to 354bebc Jan 18, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 16, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 18, 2020
Summary:
bitcoin/bitcoin@ab288b4

---

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6110
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 18, 2020
… WalletController

Summary:
bitcoin/bitcoin@32a8c6a

---

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6112
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 19, 2020
Summary:
bitcoin/bitcoin@6c49a55

---

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

  ./src/qt/bitcoin-qt -regtest -server
  ./src/bitcoin-cli -regtest createwallet test
  ./src/bitcoin-cli -regtest unloadwallet test

Changing focus to Open Wallet should reveal 'test', clicking it reveals combobox at right of interface allowing to switch between '[Default wallet]' and 'test'

Reviewers: #bitcoin_abc, jasonbcox, deadalnix

Reviewed By: #bitcoin_abc, jasonbcox, deadalnix

Subscribers: deadalnix, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D6115
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 19, 2020
…Controller

Summary:
bitcoin/bitcoin@be82dea

---

Depends on D6115

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6119
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 19, 2020
Summary:
bitcoin/bitcoin@4c8982a

---

Depends on D6119

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6121
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 19, 2020
Summary:
bitcoin/bitcoin@8847cda

---

Depends on D6121

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  as D6115

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6128
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 19, 2020
…g wallet

Summary:
bitcoin/bitcoin@1951ea4

---

Depends on D6128

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  ninja check

Run:
  ./src/qt/bitcoin-qt -regtest -server
  ./src/bitcoin-cli -regtest createwallet test
  ./src/bitcoin-cli -regtest unloadwallet test

Choose: File -> Open Wallet -> test

See a modal with "Opening wallet test" pops up then disappears

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6129
jonspock added a commit to jonspock/devault that referenced this issue Aug 14, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Aug 27, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Aug 28, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 4, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 5, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 6, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 13, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 13, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 15, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 16, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 16, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 17, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 18, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 21, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 21, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 23, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock added a commit to jonspock/devault that referenced this issue Sep 24, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
proteanx added a commit to devaultcrypto/devault that referenced this issue Sep 25, 2020
Summary:
bitcoin/bitcoin@17abc0f

---

Depends on D6084

This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]]

Test Plan:
  cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6096
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 27, 2021
1951ea4 gui: Show indeterminate progress dialog while opening walllet (João Barbosa)
8847cda gui: Add OpenWalletActivity (João Barbosa)
4c8982a interfaces: Avoid interface instance if wallet is null (João Barbosa)
be82dea gui: Add thread to run background activity in WalletController (João Barbosa)
6c49a55 gui: Add Open Wallet menu (João Barbosa)
32a8c6a gui: Add openWallet and getWalletsAvailableToOpen to WalletController (João Barbosa)
ab288b4 interfaces: Add loadWallet to Node (João Barbosa)
17abc0f wallet: Factor out LoadWallet (João Barbosa)

Pull request description:

  The *Open Wallet* menu has all the available wallets currently not loaded. The list of the available wallets comes from `listWalletDir`.

  In the future the menu can be replaced by a custom dialog.

  <img width="674" alt="screenshot 2019-01-12 at 12 17 02" src="https://user-images.githubusercontent.com/3534524/51073166-ac041480-1664-11e9-8302-be81702bc146.png">

Tree-SHA512: ebfd75eee0c8264863748899843afab67dadb7dff21313c11e3cb5b6108d954978dd1f1ae786bc07580c5a771ea4ab38d18c1643c9b9b3683ed53f0f6c582e38
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Sep 10, 2021
1951ea4 gui: Show indeterminate progress dialog while opening walllet (João Barbosa)
8847cda gui: Add OpenWalletActivity (João Barbosa)
4c8982a interfaces: Avoid interface instance if wallet is null (João Barbosa)
be82dea gui: Add thread to run background activity in WalletController (João Barbosa)
6c49a55 gui: Add Open Wallet menu (João Barbosa)
32a8c6a gui: Add openWallet and getWalletsAvailableToOpen to WalletController (João Barbosa)
ab288b4 interfaces: Add loadWallet to Node (João Barbosa)
17abc0f wallet: Factor out LoadWallet (João Barbosa)

Pull request description:

  The *Open Wallet* menu has all the available wallets currently not loaded. The list of the available wallets comes from `listWalletDir`.

  In the future the menu can be replaced by a custom dialog.

  <img width="674" alt="screenshot 2019-01-12 at 12 17 02" src="https://user-images.githubusercontent.com/3534524/51073166-ac041480-1664-11e9-8302-be81702bc146.png">

Tree-SHA512: ebfd75eee0c8264863748899843afab67dadb7dff21313c11e3cb5b6108d954978dd1f1ae786bc07580c5a771ea4ab38d18c1643c9b9b3683ed53f0f6c582e38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet