Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: bitcoin-tx doesn't need libevent, so don't pull it in #15154

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
8 participants
@luke-jr
Copy link
Member

commented Jan 12, 2019

No description provided.

@promag

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Concept ACK.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
  • #14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@kristapsk

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

utACK 8ac3414

@jgarzik
Copy link
Contributor

left a comment

ut ACK

@ken2812221

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

utACK 8ac3414

@MarcoFalke MarcoFalke merged commit 8ac3414 into bitcoin:master Jan 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Jan 13, 2019

Merge #15154: configure: bitcoin-tx doesn't need libevent, so don't p…
…ull it in

8ac3414 configure: bitcoin-tx doesn't need libevent, so don't pull it in (Luke Dashjr)

Pull request description:

Tree-SHA512: e62f6c8d443923ec91cd15e11aeb5a6faeeade6824995fc01a87aaa47390c8bfded5ae573ce78e6b39f67179ab1851fb42270df739a07a19869b49bc2f747d04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.