Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
qa: Pin shellcheck version #15166
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
referenced this pull request
Jan 15, 2019
As the shellcheck author I would definitely recommend pinning versions rather than filtering suggestions. This is because the scope of existing suggestions often changes through improvements or bugfixes.
For example, the SC2054 warning that commas won't work as an array separator recently had its detection criteria changed, so now shellcheck master (and therefore the next release) will start triggering on
By pinning, you can upgrade at your leisure without surprise build breaks.
@practicalswift Unfortunately I'm not very familiar with Travis myself.
Someone contributed a recipe which just downloads a specific release version (which could obviously be improved by verifying the checksum):
Specific ShellCheck releases can also be run via Docker, if that helps.