Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Fix wallet selector size adjustment #15167

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
5 participants
@hebasto
Copy link
Member

commented Jan 14, 2019

This PR sets QComboBox::AdjustToContents instead of default QComboBox::AdjustToContentsOnFirstShow for wallet selectors.

Before (in master):
screenshot from 2019-01-14 20-47-22

After (with this PR):
screenshot from 2019-01-14 20-48-43

@promag

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

utACK ca91661, this was on my to do list.

@molxyz

This comment has been minimized.

Copy link

commented Jan 14, 2019

Is the color of this GUI also going to be changed to this dark color?

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

Is the color of this GUI also going to be changed to this dark color?

No. There are different Qt versions. System-wide Qt handles dark theme of my DE.

@molxyz

This comment has been minimized.

Copy link

commented Jan 14, 2019

@hebasto Ah cool, thank you, good to hear.

@fanquake fanquake added the GUI label Jan 14, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

tACK ca91661 on macOS 10.14.2 (qt 5.12.0)

Note that on macOS if the window is too small to fit the longest wallet name between "Transactions" and the edge of the screen, the wallet selector turns into ">>" and appears below the other tabs. i.e:
selector below tabs

However that section folds up when you mouse away 👍

Other screenshots of ca91661 usage:
long wallet name
selection
after selected before fold

@laanwj laanwj merged commit ca91661 into bitcoin:master Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 21, 2019

Merge #15167: qt: Fix wallet selector size adjustment
ca91661 Fix wallet selector size adjustment (Hennadii Stepanov)

Pull request description:

  This PR sets `QComboBox::AdjustToContents` instead of default `QComboBox::AdjustToContentsOnFirstShow` for wallet selectors.

  Before (in master):
  ![screenshot from 2019-01-14 20-47-22](https://user-images.githubusercontent.com/32963518/51133771-83d00d80-183e-11e9-812c-3a1119fa766e.png)

  After (with this PR):
  ![screenshot from 2019-01-14 20-48-43](https://user-images.githubusercontent.com/32963518/51133788-90546600-183e-11e9-8394-eb62a998b90f.png)

Tree-SHA512: c23ac91905bb31aaa32f2fccc02b01f5707d8b094020fe6a75a9e099e78f9191670474920234a01c46480f67d3d311f44ff46f1f4202cd50a4a6d4d09a8342ce

@hebasto hebasto deleted the hebasto:20190114-wallet-selector-size-adjust branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.