Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop macports support #15175

Merged
merged 1 commit into from Jan 19, 2019
Merged

build: Drop macports support #15175

merged 1 commit into from Jan 19, 2019

Conversation

@Empact
Copy link
Member

@Empact Empact commented Jan 16, 2019

It's unmaintained, according to @theuni.
https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 16, 2019

Concept ACK.
If it's unmaintained it should be removed, simple as that.
Unless someone cares enough and promises to pick this up.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 16, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
  • #14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 16, 2019

Concept ACK. Doing this has been mentioned many times. Macports instructions were dropped from the macOS build readme in #4939 (>4 years ago, discussion in #4917), and I don't think anyone has complained/asked to have them re-added.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jan 16, 2019

Concept ACK

Unsupported stuff should go.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Jan 16, 2019
@promag
Copy link
Member

@promag promag commented Jan 16, 2019

Concept ACK and change LGTM.

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 16, 2019

"AppVeyor was unable to build non-mergeable pull request " huh

@Empact
Copy link
Member Author

@Empact Empact commented Jan 16, 2019

"AppVeyor was unable to build non-mergeable pull request " huh

Rebasing cleared this up.

@jonasschnelli
Copy link
Member

@jonasschnelli jonasschnelli commented Jan 17, 2019

Tested ACK 4e81438

@Empact
Copy link
Member Author

@Empact Empact commented Jan 17, 2019

This also removes the last remaining references to qt4 :P

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 17, 2019

Gitian builds for commit fcb6694 (master):

Gitian builds for commit 823929563fbd52b8c9aca6af2d479c8ca183f51a (master and this pull):

@IlyasRidhuan
Copy link

@IlyasRidhuan IlyasRidhuan commented Jan 18, 2019

utAck

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 18, 2019

utACK 4e81438

@theuni
Copy link
Member

@theuni theuni commented Jan 18, 2019

utACK 4e81438. Thanks!

@jonasschnelli jonasschnelli merged commit 4e81438 into bitcoin:master Jan 19, 2019
2 checks passed
jonasschnelli added a commit that referenced this issue Jan 19, 2019
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
@rex4539
Copy link
Contributor

@rex4539 rex4539 commented Jan 19, 2019

For the poor soul that may come here in the future, trying to compile using MacPorts.

Add the following to your Bash .profile:

export BDB_CFLAGS=/opt/local/include/db48/
export CPPFLAGS="$CPPFLAGS -isystem /opt/local/include"
export LIBS="$LIBS -L/opt/local/lib"
export CPPFLAGS="$CPPFLAGS -I/opt/local/include/db48"
export LIBS="$LIBS -L/opt/local/lib/db48"

Restart your shell.

Bitcoin Core will now compile.

@Empact Empact deleted the drop-macports branch Jan 19, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 17, 2020
Summary:
```
It's untested / unmaintained, according to theuni.
https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938
```

Clearly unused by ABC.

Backport of core [[bitcoin/bitcoin#15175 | PR15175]].

Test Plan:
  ninja osx-dmg

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7968
random-zebra added a commit to random-zebra/PIVX that referenced this issue Jun 11, 2021
a68c7d5 depends: mac_alias 2.2.0 (fanquake)
d8e2baf doc: Add explicit macdeployqtplus dependencies install step (Hennadii Stepanov)
013305d macdeploy: use Python 3.6 (fanquake)
faf77c3 macdeploy: remove runHDIUtil in favor of directly calling subprocess.run (fanquake)
8bcfd58 macdeploy: remove existing PIVX-Core.dmg if present (fanquake)
023d3ca macdeploy: move qt_conf to where it's used (fanquake)
7cdb5bb macdeploy: consolidate .DS_Store generation (fanquake)
4da04d7 macdeploy: assume plistlib is available (fanquake)
56ab77a macdeploy: have a single level of logging output (fanquake)
d111cdf macdeploy: remove add-resources argument (fanquake)
4312410 macdeploy: remove codesigning argument (fanquake)
c2ee635 build: automatically determine macOS translations (fanquake)
1c44ecf scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake)
c854f78 scripts: misc cleanups in macdeployqtplus (fanquake)
a3873ea scripts: use format() in macdeployqtplus (fanquake)
a65bea5 scripts: add type annotations to macdeployqtplus (fanquake)
ba179e5 build: Drop macports support (Ben Woosley)

Pull request description:

  This is a companion to PIVX-Project#2272 that focuses on on the `.dmg` creation aspect of macOS builds (ie, `make deploy`). The following upstream PRs are backported here:
   - bitcoin#15175
   - bitcoin#16477
   - bitcoin#20422
   - bitcoin#20890
   - bitcoin#21658

  Also worth mentioning: This drops support for MacPorts entirely, which has been antiquated and un-maintained for quite some time, and never actually used by any PIVX macOS build doc.

ACKs for top commit:
  furszy:
    Tested using depends, ACK a68c7d5.
  random-zebra:
    utACK a68c7d5 and merging...

Tree-SHA512: 3e9fa81a905ca3e90f07ff1213ec69dd1220a19a6a215f256ab67f2594476dc95e8fe88f15a1c9f3314b1757a7a2e5d8e6d7a790d85c117bf4236a3833757430
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet