Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop macports support #15175

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
@Empact
Copy link
Member

commented Jan 16, 2019

It's unmaintained, according to @theuni.
https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Concept ACK.
If it's unmaintained it should be removed, simple as that.
Unless someone cares enough and promises to pick this up.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
  • #14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Concept ACK. Doing this has been mentioned many times. Macports instructions were dropped from the macOS build readme in #4939 (>4 years ago, discussion in #4917), and I don't think anyone has complained/asked to have them re-added.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Concept ACK

Unsupported stuff should go.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Jan 16, 2019

@promag

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Concept ACK and change LGTM.

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

"AppVeyor was unable to build non-mergeable pull request " huh

@Empact Empact force-pushed the Empact:drop-macports branch to 4e81438 Jan 16, 2019

@Empact

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

"AppVeyor was unable to build non-mergeable pull request " huh

Rebasing cleared this up.

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Tested ACK 4e81438

@Empact

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2019

This also removes the last remaining references to qt4 :P

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Gitian builds for commit fcb6694 (master):

Gitian builds for commit 823929563fbd52b8c9aca6af2d479c8ca183f51a (master and this pull):

@IlyasRidhuan

This comment has been minimized.

Copy link

commented Jan 18, 2019

utAck

@fanquake

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

utACK 4e81438

@theuni

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

utACK 4e81438. Thanks!

@jonasschnelli jonasschnelli merged commit 4e81438 into bitcoin:master Jan 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jan 19, 2019

Merge #15175: build: Drop macports support
4e81438 build: Drop macports support (Ben Woosley)

Pull request description:

  It's unmaintained, according to @theuni.
  https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

  Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27
@rex4539

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

For the poor soul that may come here in the future, trying to compile using MacPorts.

Add the following to your Bash .profile:

export BDB_CFLAGS=/opt/local/include/db48/
export CPPFLAGS="$CPPFLAGS -isystem /opt/local/include"
export LIBS="$LIBS -L/opt/local/lib"
export CPPFLAGS="$CPPFLAGS -I/opt/local/include/db48"
export LIBS="$LIBS -L/opt/local/lib/db48"

Restart your shell.

Bitcoin Core will now compile.

@Empact Empact deleted the Empact:drop-macports branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.