Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: Improve tests and documention of /headers and /block #15177

Merged
merged 3 commits into from Jan 21, 2019

Conversation

Projects
None yet
5 participants
@promag
Copy link
Member

commented Jan 16, 2019

Follow up of #15107.

@fanquake fanquake added the Docs label Jan 16, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

utACK

@promag promag force-pushed the promag:2019-01-restheadersdoc branch to 7cf994d Jan 16, 2019

@promag promag changed the title doc: Explain empty result of /rest/headers Improve tests and documention of /rest/headers and /rest/block Jan 16, 2019

@promag

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Now with /rest/block documentation and test improvement.

@promag promag changed the title Improve tests and documention of /rest/headers and /rest/block rest: Improve tests and documention of /headers and /block Jan 16, 2019

@hebasto

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

utACK 7cf994d
nit: I'm inclined do not use contractions in the docs.

# Check result if block is not in the active chain
self.nodes[0].invalidateblock(bb_hash)
assert_equal(self.test_rest_request('/headers/1/{}'.format(bb_hash)), [])
self.test_rest_request('/block/{}'.format(bb_hash))

This comment has been minimized.

Copy link
@Empact

Empact Jan 17, 2019

Member

nit: could be more clear to make explicit what test_rest_request default args you're finding most relevant here

This comment has been minimized.

Copy link
@promag

promag Jan 18, 2019

Author Member

Maybe explicit status=200?

@Empact

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

utACK 7cf994d could squash

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

utACK 7cf994d

@laanwj laanwj merged commit 7cf994d into bitcoin:master Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 21, 2019

Merge #15177: rest: Improve tests and documention of /headers and /block
7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of #15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03

@promag promag deleted the promag:2019-01-restheadersdoc branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.