Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: Improve tests and documention of /headers and /block #15177

Merged
merged 3 commits into from Jan 21, 2019

Conversation

@promag
Copy link
Member

@promag promag commented Jan 16, 2019

Follow up of #15107.

@fanquake fanquake added the Docs label Jan 16, 2019
@laanwj
Copy link
Member

@laanwj laanwj commented Jan 16, 2019

utACK

@promag promag force-pushed the 2019-01-restheadersdoc branch from efc5d70 to 7cf994d Jan 16, 2019
@promag promag changed the title doc: Explain empty result of /rest/headers Improve tests and documention of /rest/headers and /rest/block Jan 16, 2019
@promag
Copy link
Member Author

@promag promag commented Jan 16, 2019

Now with /rest/block documentation and test improvement.

@promag promag changed the title Improve tests and documention of /rest/headers and /rest/block rest: Improve tests and documention of /headers and /block Jan 16, 2019
@hebasto
Copy link
Member

@hebasto hebasto commented Jan 16, 2019

utACK 7cf994d
nit: I'm inclined do not use contractions in the docs.

# Check result if block is not in the active chain
self.nodes[0].invalidateblock(bb_hash)
assert_equal(self.test_rest_request('/headers/1/{}'.format(bb_hash)), [])
self.test_rest_request('/block/{}'.format(bb_hash))
Copy link
Member

@Empact Empact Jan 17, 2019

nit: could be more clear to make explicit what test_rest_request default args you're finding most relevant here

Copy link
Member Author

@promag promag Jan 18, 2019

Maybe explicit status=200?

@Empact
Copy link
Member

@Empact Empact commented Jan 17, 2019

utACK 7cf994d could squash

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 21, 2019

utACK 7cf994d

@laanwj laanwj merged commit 7cf994d into bitcoin:master Jan 21, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 21, 2019
7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of #15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03
@promag promag deleted the 2019-01-restheadersdoc branch Jan 21, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Nov 10, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#15177 | PR15177]]

Test Plan: `ninja && test/functional/test_runner.py interface_rest`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8355
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
…and /block

7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of bitcoin#15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
…and /block

7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of bitcoin#15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
…and /block

7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of bitcoin#15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
…and /block

7cf994d qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7 doc: Explain empty result of /rest/headers (João Barbosa)

Pull request description:

  Follow up of bitcoin#15107.

Tree-SHA512: a7fdeed05216e3eda9604664db529237c2d0ddf422cfac139d6345a22b6e00bfe870d4e3f177423db7d4efb295ac2dc0ca2eb20c9c27c0719b89fd5428860d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants