Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment describing fDisconnect behavior #15194

Merged
merged 1 commit into from Jan 20, 2019

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Jan 17, 2019

Motivated by @Sjors here: #14605 (comment)

@Sjors
Copy link
Member

@Sjors Sjors commented Jan 18, 2019

Concept ACK, assuming it's correct :-)

@sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Jan 18, 2019

utACK

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 20, 2019

utACK 5b4283c

@laanwj laanwj merged commit 5b4283c into bitcoin:master Jan 20, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 20, 2019
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: #14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
@@ -689,6 +689,8 @@ class CNode
bool m_limited_node{false}; //after BIP159, set by version message
const bool fInbound;
std::atomic_bool fSuccessfullyConnected{false};
// Setting fDisconnect to true will cause the node to be disconnected the
// next time DisconnectNodes() runs
Copy link
Member

@MarcoFalke MarcoFalke Jan 25, 2019

nit: would be nice to use doxygen compatible comments (see developer notes and https://dev.visucore.com/bitcoin/doxygen/class_c_node.html#adebd9bb3224ed2c5ab63fdfd9c6e9074)

Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 21, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 23, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Aug 24, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
5b4283c Add comment describing fDisconnect behavior (Carl Dong)

Pull request description:

  Motivated by @Sjors here: bitcoin#14605 (comment)

Tree-SHA512: 8fc52eb4d3b5651c19c49b47fad75e8fb939cf524ada647e88d8d5aad7726052d94e500c1ebdb2a41b67bc4669ee61ff151a5cff81a52c68c900da562ef21751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants