Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq: log outbound message high water mark when reusing socket #15209

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
4 participants
@fanquake
Copy link
Member

commented Jan 19, 2019

Running master with src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq:

2019-01-19T14:11:01Z zmq: version 4.3.1
2019-01-19T14:11:01Z zmq: Initialize notification interface
2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

This PR:

2019-01-19T14:06:57Z zmq: version 4.3.1
2019-01-19T14:06:57Z zmq: Initialize notification interface
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
@molxyz

This comment has been minimized.

Copy link

commented Jan 19, 2019

@fanquake How do you get the zmq log? I'm trying to run this PR but I don't see the log for zmq in my debug.log.

@fanquake

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2019

@molxyz Run with -debug=zmq and you should see zmq related logs. I should have added that to the PR text.

@molxyz

This comment has been minimized.

Copy link

commented Jan 20, 2019

@fanquake Thank you! I should have figured that. This is great.

2019-01-20T01:35:49Z zmq: version 4.2.5
2019-01-20T01:35:49Z zmq: Initialize notification interface
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28334 is 12345
2019-01-20T01:35:49Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28335 is 5000
2019-01-20T01:35:49Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28335)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T01:35:49Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28333 is 1000
2019-01-20T01:35:49Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28333)

Edit: Changed one of the ports to be the same like the other:

2019-01-20T01:56:54Z zmq: version 4.2.5
2019-01-20T01:56:54Z zmq: Initialize notification interface
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28334 is 12345
2019-01-20T01:56:54Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:56:54Z zmq: Reusing socket for address tcp://127.0.0.1:28334
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28334 is 5000
2019-01-20T01:56:54Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T01:56:54Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28333 is 1000
2019-01-20T01:56:54Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28333)
@IlyasRidhuan

This comment has been minimized.

Copy link

commented Jan 20, 2019

tAck f1dc693

2019-01-20T13:22:25Z zmq: version 4.2.3
2019-01-20T13:22:25Z zmq: Initialize notification interface
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-20T13:22:25Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-20T13:22:25Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T13:22:25Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-20T13:22:25Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

utACK f1dc693

@laanwj laanwj merged commit f1dc693 into bitcoin:master Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 21, 2019

Merge #15209: zmq: log outbound message high water mark when reusing …
…socket

f1dc693 zmq: log outbound message high water mark when reusing socket (fanquake)

Pull request description:

  Running master with `src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq`:
  ```
  2019-01-19T14:11:01Z zmq: version 4.3.1
  2019-01-19T14:11:01Z zmq: Initialize notification interface
  2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

  This PR:
  ```
  2019-01-19T14:06:57Z zmq: version 4.3.1
  2019-01-19T14:06:57Z zmq: Initialize notification interface
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
  2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

Tree-SHA512: 6915184d8a0f4764f1cc76dce0099eed411a123d7a4bc8cee1664bb5a233a8119ddd2c78ad980c6e1d9f6dadaba48800ee6bc57de906d4e1b4108df745f1458e

@fanquake fanquake deleted the fanquake:zmq-always-log-high-water-mark branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.