Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts and tools: Replace script name with a special parameter #15216

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@hebasto
Copy link
Member

commented Jan 20, 2019

This PR improves UX; all others shell scripts (excluding travis linters) in the bitcoin repo have this feature.

Before:
screenshot from 2019-01-20 17-45-42

After:
screenshot from 2019-01-20 18-30-27

cc: @jamesob @laanwj

@practicalswift

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

utACK 5650199

@Empact

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

How about the same in test/lint/lint-whitespace.sh?

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2019

@Empact

How about the same in test/lint/lint-whitespace.sh?

I saw similar issues in that script and miss it intentionally. IIUC, it runs in the Travis environment and a user does not run it directly.
Right?

@Empact

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

Can be run in development, and it's the only case where this can be applied. May as well, IMO.

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2019

@Empact

How about the same in test/lint/lint-whitespace.sh?

Done.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

utACK 29cb24f

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

You have two commits with exactly the same title. Please squash.

@hebasto hebasto force-pushed the hebasto:20190120-improve-shell-ux branch from 29cb24f to 8c9b8a3 Feb 12, 2019

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

Squashed.

@MarcoFalke MarcoFalke merged commit 8c9b8a3 into bitcoin:master Feb 12, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

MarcoFalke added a commit that referenced this pull request Feb 12, 2019

Merge #15216: Scripts and tools: Replace script name with a special p…
…arameter

8c9b8a3 Replace script name with special parameter (Hennadii Stepanov)

Pull request description:

  This PR improves UX; all others shell scripts ~(excluding travis linters)~ in the bitcoin repo have this feature.

  Before:
  ![screenshot from 2019-01-20 17-45-42](https://user-images.githubusercontent.com/32963518/51442159-b5cfec80-1ce2-11e9-8017-3b0b464ccaf8.png)

  After:
  ![screenshot from 2019-01-20 18-30-27](https://user-images.githubusercontent.com/32963518/51442166-bf595480-1ce2-11e9-9520-481518c3b288.png)

  cc: @jamesob @laanwj

Tree-SHA512: 7924e5658a2efe81fd5591390ca5af1ff0558bd9d5693363b9f8addedb1d6b90aa16f11c9b361c6fdfbd931a959255817473a240c175dee95aefc7d2d4a10a36

@hebasto hebasto deleted the hebasto:20190120-improve-shell-ux branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.