Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: Flush state after initial sync #15218

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
@andrewtoth
Copy link
Contributor

commented Jan 20, 2019

This fixes a common issue where initial sync is done with a high dbcache and then not cleanly shut down.

Resolves #11600.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch Jan 20, 2019

src/validation.cpp Outdated

// Flush state after IBD is finished, but don't block return
void (*flush_ptr)() = &FlushStateToDisk;
std::thread(flush_ptr).detach();

This comment has been minimized.

Copy link
@practicalswift

practicalswift Jan 20, 2019

Member

Could be written as std::thread(FlushStateToDisk).detach();?

This comment has been minimized.

Copy link
@andrewtoth

andrewtoth Jan 20, 2019

Author Contributor

No, because FlushStateToDisk is overloaded and the compiler can't determine which function to call in that case.

This comment has been minimized.

Copy link
@practicalswift

practicalswift Jan 20, 2019

Member

@andrewtoth Ah, yes! Thanks!

$ git grep ' FlushStateToDisk.*{'
src/validation.cpp:bool static FlushStateToDisk(const CChainParams& chainparams, CValidationState &state, FlushStateMode mode, int nManualPruneHeight) {
src/validation.cpp:void FlushStateToDisk() {

@fanquake fanquake added the Validation label Jan 21, 2019

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch Jan 21, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

Concept ACK, but I think IsInitialBlockDownload is the wrong place to implement this, as it's a query function, having it suddenly spawn a thread that flushes is unexpected.

Would be better to implement it closer to the validation logic and database update logic itself.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch Jan 21, 2019

@andrewtoth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@laanwj Good point. I refactored to move this behaviour to ActivateBestChain in an area where periodic flushes are already expected.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch Jan 22, 2019

src/validation.cpp Outdated
static bool initially_in_ibd = true;
bool finished_ibd = initially_in_ibd && !IsInitialBlockDownload();
if (finished_ibd) {
initially_in_ibd = false;

This comment has been minimized.

Copy link
@practicalswift

practicalswift Jan 22, 2019

Member

Wrong indentation :-)

This comment has been minimized.

Copy link
@andrewtoth

andrewtoth Jan 22, 2019

Author Contributor

Fixed.

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@laanwj Good point. I refactored to move this behaviour to ActivateBestChain in an area where periodic flushes are already expected.

Thanks, much better!

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch Jan 22, 2019

src/validation.cpp Outdated
@@ -2751,7 +2751,13 @@ bool CChainState::ActivateBestChain(CValidationState &state, const CChainParams&
CheckBlockIndex(chainparams.GetConsensus());

// Write changes periodically to disk, after relay.
if (!FlushStateToDisk(chainparams, state, FlushStateMode::PERIODIC)) {
// Unless we just finished initial sync, then always write to disk
static bool initially_in_ibd = true;

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Jan 22, 2019

Member

I think that this variable should be the member of CChainState to avoid share same variable if we have two CChainState object in the program.

This comment has been minimized.

Copy link
@andrewtoth

andrewtoth Jan 23, 2019

Author Contributor

Done.

@sdaftuar

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

I'm not really a fan of this change -- the problem described in #11600 is from an unclean shutdown (ie system crash), where our recovery code could take a long time (but typically would be much faster than doing a -reindex to recover, which is how our code used to work).

This change doesn't really solve that problem, it just changes the window in which an unclean shutdown could occur (reducing it at most by 24 hours). But extra flushes, particularly during initial sync, aren't obviously a good idea, since they harm performance. (Note that we leave IBD before we've synced all the way to the tip, I think once we're within a day or two?)

Because we flush every day anyway, it's hard for me to say that this is really that much worse, performance-wise (after all we don't currently support a node configuration where the utxo is kept entirely cached). But I'm not sure this solves anything either, and a change like this would have to be reverted if, for instance, we wanted to make the cache actually more useful on startup (something I've thought we should do for a while). So I think I'm a -0 on this change.

@andrewtoth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@sdaftuar This change also greatly improves the common workflow of spinning up a high performance instance to sync, then immediately shutting it down and using a cheaper one. Currently, you have to enter it and do a clean shutdown instead of just terminating. Similarly, when syncing to an external drive, you can now just unplug the drive or turn off the machine when finished.

I would argue that moving the window to 0 hours directly after initial sync is an objective improvement. There is a lot of data that will be lost directly after, so why risk another 24 hours? After that, the most they will lose is 24 hours worth of rolling back, instead of 10 years. Also, this change does not do any extra flushes during initial sync, only after.

I can't speak to your last point about changing the way we use the cache, since I don't know what your ideas are.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch to 4787054 Jan 23, 2019

@sdaftuar

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Currently, you have to enter it and do a clean shutdown instead of just terminating.

@andrewtoth We already support this (better, I think) with the -stopatheight argument, no?

I don't really view data that is in memory as "at risk"; I view it as a massive performance optimization that will allow a node to process new blocks at the fastest possible speed while the data hasn't yet been flushed. I also don't feel very strongly about this for the reasons I gave above, so if others want this behavior then so be it.

@sipa

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@sdaftuar Maybe this is a bit of a different discussion, but there is another option; namely supporting flushing the dirty state to disk, but without wiping it from the cache. Based on our earlier benchmarking, we wouldn't want to do this purely for maximizing IBD performance, but it could be done at specific times to minimize losses in case of crashes (the once per day flush for example, and also this IBD-is-finshed one).

@sdaftuar

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@sipa Agreed, I think that would make a lot more sense as a first pass optimization for the periodic flushes and would also work better for this purpose as well.

@gmaxwell

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

. Currently, you have to enter it and do a clean shutdown instead of just terminating.

Well with this, if you "just terminate" you're going to end up with a replay of several days blocks at start, which is still ugly, even if less bad via this.

Aside, actually if you actually shut off the computer any time during IBD you'll likely completely corrupt the state and need to reindex because we don't use fsync during IBD for performance reasons.

We really need to get background writing going, so that our writes are never more than (say) a week of blocktime behind... but that is a much bigger change, so I don't suggest "just do that instead", though it would make the change here completely unnecessary.

Might it be better to trigger the flush the first time it goes 30 seconds without connecting a block and there are no queued transfers, from the scheduler thread?

@andrewtoth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

@andrewtoth We already support this (better, I think) with the -stopatheight argument, no?

@sdaftuar Ahh, I never considered using that for this purpose. Thanks!

@gmaxwell It might still be ugly to have a replay of a few days, but much better than making everything unusable for hours.

There are comments from several people in this PR about adding background writing and writing dirty state to disk without wiping the cache. This change wouldn't affect either of those improvements, and is an improvement by itself in the interim.

As for moving this to the scheduler thread, I think this is better since it happens in a place where periodic flushes are already expected Also, checking every 30 seconds for a new block wouldn't work if for instance the network cuts out for a few minutes.

@sipa

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

@andrewtoth The problem is that right now, causing a flush when exiting IBD will (temporarily) kill your performance right before finishing the sync (because it leaves you with an empty cache). If instead it was a non-clearing flush, there would be no such downside.

@sdaftuar

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

My experiment in #15265 has changed my view on this a bit -- now I think that we might as well make a change like this for now, but should change the approach slightly to do something like @gmaxwell's proposal so that we don't trigger the flush before we are done syncing:

Might it be better to trigger the flush the first time it goes 30 seconds without connecting a block and there are no queued transfers, from the scheduler thread?

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch 2 times, most recently from f1be35e to 442db9d Feb 10, 2019

@andrewtoth

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2019

@sdaftuar @gmaxwell I've updated this to check every 30 seconds on the scheduler thread if there has been an update to the active chain height. This only actually checks after IsInitialBlockDownload is false, which happens if latest block is within a day of the current time.

I'm not sure how to check if there are queued transfers. If this is not sufficient, some guidance on how to do that would be appreciated.

Show resolved Hide resolved src/init.cpp Outdated

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch 2 times, most recently from 79a9ed2 to 3abbfb0 Feb 10, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15367 (feature: Added ability for users to add a startup command by benthecarman)
  • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch 2 times, most recently from 6775fba to 8d2a650 Feb 14, 2019

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch from 8d2a650 to 8ecd177 Mar 10, 2019

Show resolved Hide resolved src/init.cpp Outdated

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch 2 times, most recently from c95cc37 to 4ff12b7 Apr 19, 2019

Show resolved Hide resolved src/init.cpp Outdated
{
// Once initial sync is finished, flush state to protect against data loss
if (IsInitialBlockDownload()) {
scheduler.scheduleFromNow(*FlushAfterSync, SYNC_CHECK_INTERVAL * 1000);

This comment has been minimized.

Copy link
@luke-jr

luke-jr Apr 19, 2019

Member

I don't understand the purpose of * before FlushAfterSync.

This comment has been minimized.

Copy link
@andrewtoth

andrewtoth Apr 19, 2019

Author Contributor

Removed them.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch from 4ff12b7 to 6471856 Apr 19, 2019

@luke-jr
Copy link
Member

left a comment

utACK

Show resolved Hide resolved src/init.cpp Outdated

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch 4 times, most recently from b3770f4 to 5d9aa4c Apr 20, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

utACK 5d9aa4c

@sdaftuar

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

I'm not sure how to check if there are queued transfers. If this is not sufficient, some guidance on how to do that would be appreciated.

There's a variable called nPeersWithValidatedDownloads in net_processing.cpp which indicates how many peers we are downloading blocks from. So to implement @gmaxwell's suggestion I think you would just need to expose that variable and then check to see if it equals 0.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch from 5d9aa4c to 44e0182 Apr 23, 2019

@andrewtoth

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@sdaftuar Thanks. Updated.

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch from 44e0182 to 6f76c4f Apr 23, 2019

Show resolved Hide resolved src/net_processing.cpp Outdated

@andrewtoth andrewtoth force-pushed the andrewtoth:flush-after-ibd branch from 6f76c4f to b32fca5 Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.