Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Enable python linters via an array #15219

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
4 participants
@Empact
Copy link
Member

commented Jan 21, 2019

This assures consistent recording of the enabled linters.

This applies the same fix as #15170 to lint-python.sh

lint: Enable python linters via an array
This assures consistent recording of the enabled linters.
@practicalswift

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

utACK 948d8f4

Much nicer. Thanks for doing this!

@@ -1,4 +1,4 @@
#!/bin/sh
#!/usr/bin/env bash

This comment has been minimized.

Copy link
@laanwj

laanwj Jan 21, 2019

Member

Adding a specific dependency on bash is acceptable, because other linter scripts already rely on bash-isms anyway, I suppose?

Edit: ah yes, I see this was one of the few scripts in lint that didn't have a specific bash shebang.

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

utACK 948d8f4

@laanwj laanwj merged commit 948d8f4 into bitcoin:master Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 21, 2019

Merge #15219: lint: Enable python linters via an array
948d8f4 lint: Enable python linters via an array (Ben Woosley)

Pull request description:

  This assures consistent recording of the enabled linters.

  This applies the same fix as #15170 to lint-python.sh

Tree-SHA512: 6d03f919e86e7c2465475c88b25dd84391282bcc11728078024daf0432a7dccddf9e4a2cdae35d6ef374971cb4e12f0fa21b58f757e25f2fe7c12ceb4f4b2c57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.