Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated mentions of signrawtransaction from fundraw help #15245

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Jan 24, 2019

RPC call has been removed as of 0.17.99.

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 25, 2019

Concept ACK. There are a couple other mentions that can also be updated:

"See signrawtransaction docs for format of sighash flags, JSON objects.", false, OptionsCategory::COMMANDS);

* It also allows you to sign a double-spend directly in signrawtransaction,

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 26, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@instagibbs
Copy link
Member Author

@instagibbs instagibbs commented Jan 29, 2019

Removed all mentions of signrawtransaction I could find(that weren't documentation says it was being removed or not to make RPC calls like it)

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Jan 29, 2019
@instagibbs
Copy link
Member Author

@instagibbs instagibbs commented Feb 4, 2019

rebased

@fanquake
Copy link
Member

@fanquake fanquake commented Feb 4, 2019

@instagibbs Looks like you've lost the other signrawtransaction changes.

@instagibbs instagibbs force-pushed the fundraw_signraw branch 2 times, most recently from a0fce23 to e79bd1e Feb 4, 2019
@instagibbs
Copy link
Member Author

@instagibbs instagibbs commented Feb 4, 2019

@fanquake fixed, and noticed I was typing "withprivkey" sometimes, so fixed those as well.

"\nSend the transaction\n"
+ HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
+ HelpExampleCli("sendrawtransactionwithwallet", "\"signedtransactionhex\"")
Copy link
Contributor

@kristapsk kristapsk Feb 4, 2019

It's still sendrawtransaction, not sendrawtransactionwithwallet.

Copy link
Member Author

@instagibbs instagibbs Feb 4, 2019

that's an error I introduced, oops

Copy link
Contributor

@kristapsk kristapsk left a comment

utACK 851380c

@fanquake
Copy link
Member

@fanquake fanquake commented Feb 4, 2019

utACK 851380c

@MarcoFalke MarcoFalke merged commit 851380c into bitcoin:master Feb 5, 2019
2 checks passed
MarcoFalke added a commit that referenced this issue Feb 5, 2019
…undraw help

851380c remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders)

Pull request description:

  RPC call has been removed as of 0.17.99.

Tree-SHA512: a6a12a0e4572acd9b532c1719be85ed6f29d1c1a28f9ce691398528b8dde4fb4a3222b8f68632fcb1a8eddfe2d31e96d5efd5bc51c041af8e7cb99b61ca3a167
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jul 8, 2020
…m fundraw help

Summary:
851380ce17 remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders)

Pull request description:

  RPC call has been removed as of 0.17.99.

---

Backport of Core [[bitcoin/bitcoin#15245 | PR15245]]

Test Plan:
  none

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6846
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 5, 2021
… from fundraw help

851380c remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders)

Pull request description:

  RPC call has been removed as of 0.17.99.

Tree-SHA512: a6a12a0e4572acd9b532c1719be85ed6f29d1c1a28f9ce691398528b8dde4fb4a3222b8f68632fcb1a8eddfe2d31e96d5efd5bc51c041af8e7cb99b61ca3a167
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 6, 2021
… from fundraw help

851380c remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders)

Pull request description:

  RPC call has been removed as of 0.17.99.

Tree-SHA512: a6a12a0e4572acd9b532c1719be85ed6f29d1c1a28f9ce691398528b8dde4fb4a3222b8f68632fcb1a8eddfe2d31e96d5efd5bc51c041af8e7cb99b61ca3a167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants