Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Use wallet to retrieve raw transactions #15247

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@MarcoFalke
Copy link
Member

commented Jan 24, 2019

Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests.

This refactoring only makes sense in light of #15159.

This product may contain minor stylistic cleanups

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-qaWalletRaw branch from fa258ea to fac7311 Jan 24, 2019

@jnewbery

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

I think it's good to improve code style in files that you touch, but could you split this into commits:

  • one that improves code style
  • one that changes behaviour

doing both in a single commit makes is discouraged: do not mix any formatting fixes or code moves with actual code changes.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-qaWalletRaw branch from fac7311 to fa2320a Jan 25, 2019

@jnewbery
Copy link
Member

left a comment

Tested ACK fa2320a. One nit.

Show resolved Hide resolved test/functional/wallet_abandonconflict.py Outdated

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-qaWalletRaw branch from fa2320a to fa5278a Jan 27, 2019

@jnewbery

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

tACK fa5278a. Thanks!

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 1, 2019

Merge bitcoin#15247: qa: Use wallet to retrieve raw transactions
fa5278a qa: Use wallet to retrieve raw transactions (MarcoFalke)
fa21983 qa: Style-only fixes in touched files (MarcoFalke)

Pull request description:

  Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests.

  This refactoring only makes sense in light of bitcoin#15159.

  <sub>This product may contain minor stylistic cleanups

Tree-SHA512: ec34c7150d873da9f19fead3f7e3f758baba5ef10061942384c470a47a6f320690109be9c5160f0c8bc228272a729653d44c78471455337318f657d6c164ba23

@MarcoFalke MarcoFalke merged commit fa5278a into bitcoin:master Feb 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1901-qaWalletRaw branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.