Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct logging return type and RPC example #15272

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
5 participants
@fanquake
Copy link
Member

commented Jan 27, 2019

Logging status is returned as a bool.

src/bitcoin-cli logging "[\"all\"]" "[\"http\"]"
{
  "net": true,
  "tor": true,
  "mempool": true,
  "http": false,
  "bench": true,
  "zmq": true,
  "db": true,
  "rpc": true,
  "estimatefee": true,
  "addrman": true,
  "selectcoins": true,
  "reindex": true,
  "cmpctblock": true,
  "rand": true,
  "prune": true,
  "proxy": true,
  "mempoolrej": true,
  "libevent": true,
  "coindb": true,
  "qt": true,
  "leveldb": true
}

Also corrects the RPC example so that libevent logging will actually be turned off.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jan 27, 2019

ACK, probably happened as side effect of bitcoin-core/univalue@51d3ab3 ?

@promag

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

ACK d014908, a test would be 👍

@fanquake fanquake force-pushed the fanquake:rpc-logging-return-example branch from d014908 to e1c27da Jan 29, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

re-ACK

@promag

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

ACK e1c27da, only change is rebase.

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

utACK e1c27da (verified that it indeed returns bools)

@laanwj laanwj merged commit e1c27da into bitcoin:master Jan 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 31, 2019

Merge #15272: doc: correct logging return type and RPC example
e1c27da doc: correct logging rpc return type and example (fanquake)

Pull request description:

  Logging status is returned as a bool.
  ```
  src/bitcoin-cli logging "[\"all\"]" "[\"http\"]"
  {
    "net": true,
    "tor": true,
    "mempool": true,
    "http": false,
    "bench": true,
    "zmq": true,
    "db": true,
    "rpc": true,
    "estimatefee": true,
    "addrman": true,
    "selectcoins": true,
    "reindex": true,
    "cmpctblock": true,
    "rand": true,
    "prune": true,
    "proxy": true,
    "mempoolrej": true,
    "libevent": true,
    "coindb": true,
    "qt": true,
    "leveldb": true
  }
  ```

  Also corrects the RPC example so that `libevent` logging will actually be turned off.

Tree-SHA512: 2de7130df51688d2d6636c12fd56326362794118a10efc8100f0bf541a7da00a12a6cd9d75e599a104513a050bbe49b418ea460ee8033ac6cf6ffb8e8e9140d6

@fanquake fanquake deleted the fanquake:rpc-logging-return-example branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.