Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct logging return type and RPC example #15272

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 27, 2019

Logging status is returned as a bool.

src/bitcoin-cli logging "[\"all\"]" "[\"http\"]"
{
  "net": true,
  "tor": true,
  "mempool": true,
  "http": false,
  "bench": true,
  "zmq": true,
  "db": true,
  "rpc": true,
  "estimatefee": true,
  "addrman": true,
  "selectcoins": true,
  "reindex": true,
  "cmpctblock": true,
  "rand": true,
  "prune": true,
  "proxy": true,
  "mempoolrej": true,
  "libevent": true,
  "coindb": true,
  "qt": true,
  "leveldb": true
}

Also corrects the RPC example so that libevent logging will actually be turned off.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 27, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 27, 2019

ACK, probably happened as side effect of bitcoin-core/univalue-subtree@51d3ab3 ?

@promag
Copy link
Member

@promag promag commented Jan 28, 2019

ACK d014908, a test would be 👍

@fanquake fanquake force-pushed the rpc-logging-return-example branch from d014908 to e1c27da Jan 29, 2019
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 29, 2019

re-ACK

@promag
Copy link
Member

@promag promag commented Jan 29, 2019

ACK e1c27da, only change is rebase.

@laanwj
Copy link
Member

@laanwj laanwj commented Jan 31, 2019

utACK e1c27da (verified that it indeed returns bools)

@laanwj laanwj merged commit e1c27da into bitcoin:master Jan 31, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 31, 2019
e1c27da doc: correct logging rpc return type and example (fanquake)

Pull request description:

  Logging status is returned as a bool.
  ```
  src/bitcoin-cli logging "[\"all\"]" "[\"http\"]"
  {
    "net": true,
    "tor": true,
    "mempool": true,
    "http": false,
    "bench": true,
    "zmq": true,
    "db": true,
    "rpc": true,
    "estimatefee": true,
    "addrman": true,
    "selectcoins": true,
    "reindex": true,
    "cmpctblock": true,
    "rand": true,
    "prune": true,
    "proxy": true,
    "mempoolrej": true,
    "libevent": true,
    "coindb": true,
    "qt": true,
    "leveldb": true
  }
  ```

  Also corrects the RPC example so that `libevent` logging will actually be turned off.

Tree-SHA512: 2de7130df51688d2d6636c12fd56326362794118a10efc8100f0bf541a7da00a12a6cd9d75e599a104513a050bbe49b418ea460ee8033ac6cf6ffb8e8e9140d6
@fanquake fanquake deleted the rpc-logging-return-example branch Feb 22, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 1, 2020
Summary:
logging status is returned as a bool, not 0|1

Backport of Core [[bitcoin/bitcoin#15272 | PR15272]]

Test Plan:
```
ninja && sudo ninja install
bitcoin-cli help logging
bitcoin-cli logging "[\"all\"]" "[\"http\"]"
```

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7702
pravblockc added a commit to pravblockc/dash that referenced this issue Aug 13, 2021
e1c27da doc: correct logging rpc return type and example (fanquake)

Pull request description:

  Logging status is returned as a bool.
  ```
  src/bitcoin-cli logging "[\"all\"]" "[\"http\"]"
  {
    "net": true,
    "tor": true,
    "mempool": true,
    "http": false,
    "bench": true,
    "zmq": true,
    "db": true,
    "rpc": true,
    "estimatefee": true,
    "addrman": true,
    "selectcoins": true,
    "reindex": true,
    "cmpctblock": true,
    "rand": true,
    "prune": true,
    "proxy": true,
    "mempoolrej": true,
    "libevent": true,
    "coindb": true,
    "qt": true,
    "leveldb": true
  }
  ```

  Also corrects the RPC example so that `libevent` logging will actually be turned off.

Tree-SHA512: 2de7130df51688d2d6636c12fd56326362794118a10efc8100f0bf541a7da00a12a6cd9d75e599a104513a050bbe49b418ea460ee8033ac6cf6ffb8e8e9140d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants