Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Slight tweak to the verify-commits script directions #15273

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@droark
Copy link
Contributor

commented Jan 27, 2019

Clarify that GnuPG may be used on both Linux and macOS to obtain the keys required to verify the commits.

@droark droark force-pushed the droark:tweak_verify_commit_dirs branch from 5081272 to 9a93d4c Jan 27, 2019

@fanquake fanquake added the Docs label Jan 27, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

GnuPG is platform-independent software, it's there for Linux, Windows, Solaris, BSDs, and so on and so on, even Android. How does adding specific platforms clarify here?

Edit: so probably best to remove mention of platforms instead of adding more.

Slight tweak to the verify-commits script directions
Clarify that GnuPG may be used on both Linux and macOS to obtain the keys required to verify the commits.

@droark droark force-pushed the droark:tweak_verify_commit_dirs branch from a45f3d3 to a786c3b Jan 31, 2019

@droark

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Did a fixup. I do have one question. On my computers, I have GnuPG v1 and GnuPG v2 installed. Does anybody wish to clarify how to handle both versions (the same, I think, but I haven't tried it on v2)? I also don't know if there are systems with v2 only, and if they create some sort of link to allow gpg2 to be invoked as gpg.

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

This works as-is with both gpg v1 and gpg v2.
Newer Ubuntu and Debian default to gpg v2 and have a link, I don't know about other distributions.

-rwxr-xr-x 1 root root 1017384 jan 10 14:07 /usr/bin/gpg
lrwxrwxrwx 1 root root 3 jan 10 14:07 /usr/bin/gpg2 -> gpg

@fanquake fanquake changed the title Slight tweak to the verify-commits script directions docs: Slight tweak to the verify-commits script directions Feb 22, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

utACK a786c3b

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

utACK a786c3b

@laanwj laanwj merged commit a786c3b into bitcoin:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 22, 2019

Merge #15273: docs: Slight tweak to the verify-commits script directions
a786c3b Slight tweak to the verify-commits script directions (Douglas Roark)

Pull request description:

  Clarify that GnuPG may be used on both Linux and macOS to obtain the keys required to verify the commits.

Tree-SHA512: cec556370f03e00bbd6f585d26b360ca236cf55cb5c0996f6d950d8a98f77c92cc02f1719c8f9b9dc9eac6900eb341a13b50a012752832f39095b7e84046f2cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.