Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Compile once on trusty #15276

Merged
merged 2 commits into from Jan 30, 2019
Merged

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 28, 2019

To avoid accidentally regressing again on #15172, we should compile at least once with gcc4.8 (the minimum required version)

Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

@MarcoFalke MarcoFalke force-pushed the Mf1901-travisTrusty branch 2 times, most recently from fafbf51 to faabd19 Jan 28, 2019
@Empact
Copy link
Member

@Empact Empact commented Jan 28, 2019

See also #14998, which I haven't gotten green

@MarcoFalke MarcoFalke force-pushed the Mf1901-travisTrusty branch from faabd19 to fa0b86e Jan 28, 2019
@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Jan 28, 2019

Jup, thanks for working on this. Though, it seems your code-changes haven't seen much review, so I try to make a minimal test-only addition to get this in asap.

@MarcoFalke MarcoFalke force-pushed the Mf1901-travisTrusty branch from fa0b86e to fa5ce3f Jan 28, 2019
@Empact
Copy link
Member

@Empact Empact commented Jan 28, 2019

utACK fa5ce3f could squash

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Jan 28, 2019

I'd prefer if the top commit was reverted in the future, so having it separate helps in that regard.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jan 29, 2019

utACK fa5ce3f

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Jan 30, 2019
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
@MarcoFalke MarcoFalke merged commit fa5ce3f into bitcoin:master Jan 30, 2019
2 checks passed
@MarcoFalke MarcoFalke deleted the Mf1901-travisTrusty branch Jan 30, 2019
MarcoFalke added a commit that referenced this issue Feb 1, 2019
119d360 travis: Document whether functional tests are run in the job name (Ben Woosley)
64f2854 Revert "travis: Compile trusty with depends for now" (Ben Woosley)
267eac0 Prefer boost::optional#get_value_or over #value_or (Ben Woosley)
1971f5b Piecewise construct to avoid invalid construction (Ben Woosley)

Pull request description:

  In light of #14979, I realized that only qt 5.5+ was being tested under CI, while compatibility lists 5.2+.

  In #15276, Marco added Trusty to CI, building with depends. This changes that build to system libraries, in order to ensure ongoing compatibility with our claimed minimum required versions.

  Fixes #14983, previously open as #14998

Tree-SHA512: 6cff5e28c756ecb8bf797c8f6eb77c1944ba61a8dd6d7d4984e63eef384f6429dc79c505da3241c05b9c4db31c72b2a9846c7365aba9280f2e0620e5f3998d07
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 21, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 23, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke)
fa83999 travis: Compile once on trusty (MarcoFalke)

Pull request description:

  To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version)

  Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.

Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants