Jump to conversation
Unresolved conversations (9)
@maflcko maflcko Jun 25, 2019
Would be nice to do a rebase, so that changes already merged stop showing up here, no?
Outdated
depends/packages/xtrans.mk
fanquake
@laanwj laanwj Jun 12, 2019
` --max-jobs=$(nproc) \` ?
Outdated
contrib/guix/guix-build.sh
@laanwj laanwj Jun 9, 2019
as guix is basically a system for deterministic builds, I'm surprised our own faketime hack is still needed !
Outdated
contrib/guix/build.sh
laanwj dongcarl
fanquake
@laanwj laanwj Jun 9, 2019
In #16141, `TAR_OPTIONS` has been removed from the gitian descriptor. Do we want to do the same here?
Outdated
contrib/guix/build.sh
dongcarl
@laanwj laanwj Jun 9, 2019
Do we want this to be "in general" or a hard rule? Are there exceptions thinkable?
Outdated
depends/packages.md
dongcarl
@maflcko maflcko Feb 27, 2019
Hmm, why would we need this?
Outdated
contrib/guix/manifest.scm
@wtogami wtogami Feb 7, 2019
``` libstdc++.so.6 => /gnu/store/4sqps8dczv3g7rwbdibfz6rf5jlk7w90-gcc-5.5.0-lib/lib/libstdc++.so.6 (0x00007fb7ed87c000) ``` Your ldd output indicates that it isn't static linking libstdc++.
Outdated
contrib/guix/build.sh
@wtogami wtogami Feb 7, 2019
curl shouldn't be necessary in the container if depends is pre-populated. May require editing the depends system?
Outdated
contrib/guix/manifest.scm
@dongcarl dongcarl Jan 30, 2019
```suggestion [ -e /usr/bin/file ] || ln -s "$(command -v file)" /usr/bin/file ```
Outdated
contrib/guix/build.sh
Resolved conversations (13)
@maflcko maflcko Jul 12, 2019
Is this depends change supposed to be in the "guix" commit?
depends/packages/qt.mk
dongcarl
@maflcko maflcko Jul 12, 2019
Would be nice to explain why three different versions of gcc are used. Why is it not possible to use just one? Maybe the most popular version of gcc, which might be the one in the latest Ubuntu LTS release (we also use that version for gitian builds)
Outdated
contrib/guix/manifest.scm
dongcarl
@maflcko maflcko Jul 12, 2019
nit: Is this used somewhere?
Outdated
contrib/guix/manifest.scm
dongcarl
@maflcko maflcko Jul 12, 2019
This seems to default to the "current python 3.x" version (https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/python.scm?id=v1.0.1-828-gf434664cc0#n365) We had issues in the past where dictionary keys were sorted differently in different versions of python, so I'd prefer if the versions were somehow pinned. (Same goes for the other packages in this scm)
Outdated
contrib/guix/manifest.scm
dongcarl
@maflcko maflcko Jul 12, 2019
Could this be called `bitcoin-core` for clarity? ```suggestion (define-module (bitcoin-core) ```
Outdated
contrib/guix/manifest.scm
dongcarl
@maflcko maflcko Jul 12, 2019
```suggestion - 24GB of free disk space on the partition that the Bitcoin Core git repository resides in ```
Outdated
contrib/guix/README.md
dongcarl
@maflcko maflcko Jul 12, 2019
```suggestion # Run the build script 'contrib/guix/libexec/build.sh' in the build container ```
Outdated
contrib/guix/guix-build.sh
dongcarl
@hebasto hebasto Jun 30, 2019
See my https://github.com/bitcoin/bitcoin/pull/15277#issuecomment-507046880
contrib/guix/guix-build.sh
dongcarl
@maflcko maflcko Mar 18, 2019
``` Missing expected shebang "#!/usr/bin/env bash" or "#!/bin/sh" in contrib/guix/guix-build.sh
Outdated
contrib/guix/guix-build.sh
@fanquake fanquake Feb 15, 2019
Looks like the additions of [`--no-same-owner`](https://linux.die.net/man/1/tar) to `tar` commands inside depends is extensive.
Outdated
depends/funcs.mk
fanquake dongcarl
@fanquake fanquake Feb 15, 2019
Can you add `export LC_ALL=C` to make [Travis happy](https://travis-ci.org/bitcoin/bitcoin/jobs/488536092#L257).
Outdated
contrib/guix/build.sh
maflcko
@practicalswift practicalswift Jan 31, 2019
Should specify which shell is to be used with shebang line?
Outdated
contrib/guix/build.sh
dongcarl wtogami
@maflcko maflcko Jan 28, 2019
nit: Don't we use `$(PYTHON)` for those?
Outdated
src/Makefile.am
dongcarl