Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Clarify rescanblockchain doc #15279

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Jan 28, 2019

This was probably accidentally added to the wrong line when addressing the feedback here: #7061 (comment)

I already added the default values in #14877, but it could be clarified more that this really has no specific block height as default value, since the tip can change during a rescan.

@MarcoFalke MarcoFalke changed the title wallet: Fixup rescanblockchain result doc wallet: Clarify rescanblockchain doc Jan 28, 2019

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-docRpcRescan branch from fa8df96 to fa1484b Jan 28, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14918 (RPCHelpMan: Check default values are given at compile-time by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@promag
Copy link
Member

left a comment

ACK fa1484b, response keys are always present. Default stop_height value is dynamic so makes sense to describe it. Could just add a small note (sorry the bad wording).

Show resolved Hide resolved src/wallet/rpcwallet.cpp Outdated

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-docRpcRescan branch from fa1484b to fa5e6ef Jan 29, 2019

@promag

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

ACK fa5e6ef.

@DrahtBot DrahtBot removed the Needs rebase label Jan 29, 2019

@ryanofsky
Copy link
Contributor

left a comment

utACK fa5e6ef

@promag

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Unrelated travis failure.

For reference, the fail was:
screenshot 2019-01-29 at 21 37 10

@Empact

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

utACK fa5e6ef

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Jan 30, 2019

@MarcoFalke MarcoFalke merged commit fa5e6ef into bitcoin:master Jan 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Jan 30, 2019

Merge #15279: wallet: Clarify rescanblockchain doc
fa5e6ef wallet: Fixup rescanblockchain result doc (MarcoFalke)

Pull request description:

  This was probably accidentally added to the wrong line when addressing the feedback here: #7061 (comment)

  I already added the default values in #14877, but it could be clarified more that this really has no specific block height as default value, since the tip can change during a rescan.

Tree-SHA512: 48a3c5143e2b7129ee8f396d2e77550cb393fbe45f5936aeebeb7a201d61560336a3ae47b26bb757a4dbbe217e06abfd67a5a673aef266b6c4d7a80d049a2b49

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1901-docRpcRescan branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.