Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make bloom tests deterministic #15324

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
5 participants
@MarcoFalke
Copy link
Member

commented Feb 1, 2019

non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known.

Show resolved Hide resolved src/random.h Outdated
@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Concept ACK

Non-deterministic tests and the sources of non-determinism are documented in #15296.

@jonasschnelli jonasschnelli added the Tests label Feb 2, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known

👍
(also people are likely to re-run the tests before investigating deeply so won't learn anything from a random failure)

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1902-qaBloom branch from fa07e4f to fae169c Feb 2, 2019

@Empact

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

utACK fae169c

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

utACK fae169c

1 similar comment
@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

utACK fae169c

@laanwj laanwj merged commit fae169c into bitcoin:master Feb 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 4, 2019

Merge #15324: test: Make bloom tests deterministic
fae169c test: Make bloom tests deterministic (MarcoFalke)

Pull request description:

  non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known.

Tree-SHA512: 4f634ff0c6adf663444f1ac504f6dbceaa46b78d697b840531977ba30006453ac559d5c21cc3eaef6d92b87d46008a34b0db6331ea3318001987fcfaec634acf
@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Thanks for merging.

Reviewers of this PR might be interested in reviewing #15327 which makes the test updatecoins_simulation_test deterministic.

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-qaBloom branch Feb 4, 2019

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 5, 2019

Merge bitcoin#15327: tests: Make test updatecoins_simulation_test det…
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.