Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Make test updatecoins_simulation_test deterministic #15327

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 2, 2019

Make test updatecoins_simulation_test deterministic.

Can be verified using contrib/test_deterministic_coverage.sh introduced in #15296.

Related:

  • #15296: "tests: Add script checking for deterministic line coverage in unit tests"
  • #15324: "test: Make bloom tests deterministic"
  • #14343: "coverage reports non-deterministic"
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 2, 2019

utACK f72aea2

src/test/coins_tests.cpp Outdated Show resolved Hide resolved
@practicalswift practicalswift force-pushed the SeedInsecureRand(true); branch from f72aea2 to ef0b012 Feb 3, 2019
@practicalswift practicalswift changed the title tests: Make tests updatecoins_simulation_test and knapsack_solver_test deterministic tests: Make test updatecoins_simulation_test deterministic Feb 3, 2019
@Empact
Copy link
Member

@Empact Empact commented Feb 4, 2019

utACK ef0b012

@practicalswift
Copy link
Contributor Author

@practicalswift practicalswift commented Feb 4, 2019

@MarcoFalke Would you mind re-reviewing? It gets easier to tackle the hard non-determinism cases with the noise from these trivial cases out of the way :-)

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 4, 2019

I'd prefer to do make more than one test deterministic in its coverage, otherwise this will end up in a flood of pull requests. Unless of course one of the fixes is potentially too controversial (e.g. modifies validation code or other Core code)

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Feb 5, 2019
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
@MarcoFalke MarcoFalke merged commit ef0b012 into bitcoin:master Feb 5, 2019
2 checks passed
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jun 18, 2020
Summary: Backport of core [[bitcoin/bitcoin#15327 | PR15327]].

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6620
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Oct 16, 2020
Summary: Backport of core [[bitcoin/bitcoin#15327 | PR15327]].

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6620
@practicalswift practicalswift deleted the SeedInsecureRand(true); branch Apr 10, 2021
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
…erministic

ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make test `updatecoins_simulation_test` deterministic.

  Can be verified using `contrib/test_deterministic_coverage.sh` introduced in bitcoin#15296.

  Related:
  * bitcoin#15296: "tests: Add script checking for deterministic line coverage in unit tests"
  * bitcoin#15324: "test: Make bloom tests deterministic"
  * bitcoin#14343: "coverage reports non-deterministic"

Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants