Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix race in p2p_invalid_messages #15330

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@MarcoFalke
Copy link
Member

commented Feb 2, 2019

After we change our magic bytes, the node may or may not send us messages such as feefilter or sendheaders, which would be rejected by _on_data.

Solve that by replacing _on_data with a noop.

@MarcoFalke MarcoFalke added the Tests label Feb 2, 2019

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 2, 2019

@Empact

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

utACK fac3a05

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

utACK fac3a05

@MarcoFalke MarcoFalke merged commit fac3a05 into bitcoin:master Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Feb 3, 2019

Merge #15330: test: Fix race in p2p_invalid_messages
fac3a05 test: Fix race in p2p_invalid_messages (MarcoFalke)

Pull request description:

  After we change our magic bytes, the node may or may not send us messages such as feefilter or sendheaders, which would be rejected by `_on_data`.

  Solve that by replacing `_on_data` with a noop.

Tree-SHA512: bd25a81f0c6e31f09155e00abab8062777d827b9210d6a9b85ef35cfe5069338f100fecf058842f41a1f134fdb3cf7ac1fe80db493e4dab7988acdacb33149df

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-qaRaceMagic branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.