Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Fix for segfault if combinepsbt called with empty inputs #15337

Merged
merged 1 commit into from Feb 11, 2019

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Feb 4, 2019

Fixes #15300

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 4, 2019

Concept ACK and thanks for fixing.

Is it worth checking if we have this problem elsewhere where we're using UniValue foo = request.params[n].get_array()

@benthecarman
Copy link
Contributor Author

@benthecarman benthecarman commented Feb 4, 2019

@practicalswift I did a quick pass looking for uses of get_array() and didn't find any where else that caused a crash, however some gave errors that didn't seem to correlate with what would be going wrong.

src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved
src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved
@benthecarman benthecarman force-pushed the rpc_combinepbst_empty_fix branch from ff918eb to 30d0f7b Feb 5, 2019
@Sjors
Copy link
Member

@Sjors Sjors commented Feb 11, 2019

tACK 30d0f7b

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 11, 2019
@MarcoFalke MarcoFalke merged commit 30d0f7b into bitcoin:master Feb 11, 2019
2 checks passed
MarcoFalke added a commit that referenced this issue Feb 11, 2019
…inputs

30d0f7b rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes #15300

Tree-SHA512: 25e7b4e6e48d8b0d197f0ab96df308fff33e2110f8929cb48914877fa7f4c4a84f173b1378fdb2dec5d03fe7d6d1aced4b577e55f9fe180d8147d9106ebf543f
@benthecarman benthecarman deleted the rpc_combinepbst_empty_fix branch Feb 11, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jun 15, 2020
…ty inputs

Summary:
30d0f7be6e rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes #15300

---

Backport of Core [[bitcoin/bitcoin#15337 | PR15337]]

Test Plan:
  ninja
  test_runner.py rpc_psbt

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6590
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Aug 17, 2020
…ty inputs

Summary:
30d0f7be6e rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes #15300

---

Backport of Core [[bitcoin/bitcoin#15337 | PR15337]]

Test Plan:
  ninja
  test_runner.py rpc_psbt

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6590
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Jul 30, 2021
… empty inputs

30d0f7b rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes bitcoin#15300

Tree-SHA512: 25e7b4e6e48d8b0d197f0ab96df308fff33e2110f8929cb48914877fa7f4c4a84f173b1378fdb2dec5d03fe7d6d1aced4b577e55f9fe180d8147d9106ebf543f
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Aug 3, 2021
… empty inputs

30d0f7b rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes bitcoin#15300

Tree-SHA512: 25e7b4e6e48d8b0d197f0ab96df308fff33e2110f8929cb48914877fa7f4c4a84f173b1378fdb2dec5d03fe7d6d1aced4b577e55f9fe180d8147d9106ebf543f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants