Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Fix for segfault if combinepsbt called with empty inputs #15337

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
6 participants
@benthecarman
Copy link
Contributor

commented Feb 4, 2019

Fixes #15300

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Concept ACK and thanks for fixing.

Is it worth checking if we have this problem elsewhere where we're using UniValue foo = request.params[n].get_array()

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@practicalswift I did a quick pass looking for uses of get_array() and didn't find any where else that caused a crash, however some gave errors that didn't seem to correlate with what would be going wrong.

Show resolved Hide resolved src/rpc/rawtransaction.cpp Outdated
Show resolved Hide resolved src/rpc/rawtransaction.cpp Outdated

@benthecarman benthecarman force-pushed the benthecarman:rpc_combinepbst_empty_fix branch from ff918eb to 30d0f7b Feb 5, 2019

@Sjors

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

tACK 30d0f7b

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 11, 2019

@MarcoFalke MarcoFalke merged commit 30d0f7b into bitcoin:master Feb 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Feb 11, 2019

Merge #15337: rpc: Fix for segfault if combinepsbt called with empty …
…inputs

30d0f7b rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)

Pull request description:

  Fixes #15300

Tree-SHA512: 25e7b4e6e48d8b0d197f0ab96df308fff33e2110f8929cb48914877fa7f4c4a84f173b1378fdb2dec5d03fe7d6d1aced4b577e55f9fe180d8147d9106ebf543f

@benthecarman benthecarman deleted the benthecarman:rpc_combinepbst_empty_fix branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.