Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] netaddress: Make IPv4 loopback comment more descriptive #15343

Merged
merged 2 commits into from Feb 6, 2019

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Feb 4, 2019

This also makes the comment match the IPv6 comment just below this hunk.

src/netaddress.cpp Outdated Show resolved Hide resolved
Loading
@dongcarl dongcarl force-pushed the 2019-02-islocal-clarify branch from b991c80 to 87aa0b4 Feb 4, 2019
@dongcarl
Copy link
Contributor Author

@dongcarl dongcarl commented Feb 4, 2019

Fixed!

Loading

@MarcoFalke MarcoFalke changed the title netaddress: Make IPv4 loopback comment more descriptive [doc] netaddress: Make IPv4 loopback comment more descriptive Feb 4, 2019
@MarcoFalke MarcoFalke added the Docs label Feb 4, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Feb 5, 2019

utACK 87aa0b4

Theerror C2065: 'g_logger': undeclared identifier Appveyor failure has been fixed in #15347.

Loading

Copy link
Contributor

@kristapsk kristapsk left a comment

utACK 6180b5f

Loading

@laanwj laanwj merged commit 87aa0b4 into bitcoin:master Feb 6, 2019
2 checks passed
Loading
laanwj added a commit that referenced this issue Feb 6, 2019
…iptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jun 9, 2020
…iptive

Summary:
87aa0b48afe5a070e6e11e502a1803da6add5197 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f32bbcd7ef18db772290954161806e609e netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8

Backport of Core [[bitcoin/bitcoin#15343 | PR15343]]

Test Plan:
  ninja

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6476
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Aug 17, 2020
…iptive

Summary:
87aa0b48afe5a070e6e11e502a1803da6add5197 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f32bbcd7ef18db772290954161806e609e netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8

Backport of Core [[bitcoin/bitcoin#15343 | PR15343]]

Test Plan:
  ninja

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6476
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 24, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 1, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 5, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 9, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 10, 2021
…e descriptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants