Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] netaddress: Make IPv4 loopback comment more descriptive #15343

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
5 participants
@dongcarl
Copy link
Contributor

commented Feb 4, 2019

This also makes the comment match the IPv6 comment just below this hunk.

Show resolved Hide resolved src/netaddress.cpp Outdated

@dongcarl dongcarl force-pushed the dongcarl:2019-02-islocal-clarify branch from b991c80 to 87aa0b4 Feb 4, 2019

@dongcarl

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Fixed!

@MarcoFalke MarcoFalke changed the title netaddress: Make IPv4 loopback comment more descriptive [doc] netaddress: Make IPv4 loopback comment more descriptive Feb 4, 2019

@MarcoFalke MarcoFalke added the Docs label Feb 4, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

utACK 87aa0b4

Theerror C2065: 'g_logger': undeclared identifier Appveyor failure has been fixed in #15347.

@kristapsk
Copy link
Contributor

left a comment

utACK 6180b5f

@laanwj laanwj merged commit 87aa0b4 into bitcoin:master Feb 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 6, 2019

Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descr…
…iptive

87aa0b4 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

  This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.