Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linearize-hashes.py #15351

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
5 participants
@OverlordQ
Copy link
Contributor

commented Feb 6, 2019

Fix class case issue.

Update linearize-hashes.py
Fix class case issue.
@promag

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

ACK 7fdb92e.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Would be nice if this script was tested in ci or otherwise.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 6, 2019

Merge bitcoin#15351: Update linearize-hashes.py
7fdb92e Update linearize-hashes.py (OverlordQ)

Pull request description:

  Fix class case issue.

Tree-SHA512: 42d26e38b75b6b419ae4a9ca5c110d4ced0f7c5db997a64c8ab5dfc25dc228008349b6423c20ef4e396a773ff31f1f3f0092331c5e89748216e253e4d8337e9a

@MarcoFalke MarcoFalke merged commit 7fdb92e into bitcoin:master Feb 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Thanks for fixing this!

For next time, please use a PR title that summarizes the change, "Update linearize-hashes.py" isn't very useful to have in the commit log!

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Sorry, my bad. I missed to fix it up before merge.

@OverlordQ OverlordQ deleted the OverlordQ:patch-1 branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.