Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Add SetupHelpOptions() #15358

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Feb 6, 2019

Every binary we have sets up the help option in their own way and wording.

Solve that by having one function take care of it for all of them.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1902-Help branch from fa73f7c to a99999c Feb 6, 2019

@promag
Copy link
Member

left a comment

Concept ACK.

Show resolved Hide resolved src/util/system.cpp
@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15307 ([WIP] [tool] Add salvage and zaptxs commands to bitcoin-wallet by jnewbery)
  • #13716 (bitcoin-cli: -stdinwalletpassphrase and non-echo stdin passwords by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@@ -295,6 +295,9 @@ extern ArgsManager gArgs;
*/
bool HelpRequested(const ArgsManager& args);

/** Add help options to the args manager */
void SetupHelpOptions(ArgsManager& args);

This comment has been minimized.

Copy link
@promag

promag Feb 7, 2019

Member

nit, how about this as a member, like ArgsManager::SetupHelpOptions?

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Feb 7, 2019

Author Member

In general the args are module specific (wallet, node, gui, chain, mempool, ...) so the args manager should not know about them. This is also in line with how we Setup*Options() for all other modules.

This comment has been minimized.

Copy link
@laanwj

laanwj Feb 12, 2019

Member

Agree with @MarcoFalke here. It is not the responsibility of ArgsManager to know about or hardcode specific options.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Concept ACK

@Empact

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

utACK a99999c

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

utACK a99999c

@laanwj laanwj merged commit a99999c into bitcoin:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 12, 2019

Merge #15358: util: Add SetupHelpOptions()
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-Help branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.