Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Add SetupHelpOptions() #15358

Merged
merged 1 commit into from Feb 12, 2019
Merged

util: Add SetupHelpOptions() #15358

merged 1 commit into from Feb 12, 2019

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 6, 2019

Every binary we have sets up the help option in their own way and wording.

Solve that by having one function take care of it for all of them.

Copy link
Member

@promag promag left a comment

Concept ACK.

src/util/system.cpp Show resolved Hide resolved
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 6, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15307 ([WIP] [tool] Add salvage and zaptxs commands to bitcoin-wallet by jnewbery)
  • #13716 (bitcoin-cli: -stdinwalletpassphrase and non-echo stdin passwords by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@@ -295,6 +295,9 @@ extern ArgsManager gArgs;
*/
bool HelpRequested(const ArgsManager& args);

/** Add help options to the args manager */
void SetupHelpOptions(ArgsManager& args);
Copy link
Member

@promag promag Feb 7, 2019

nit, how about this as a member, like ArgsManager::SetupHelpOptions?

Copy link
Member Author

@MarcoFalke MarcoFalke Feb 7, 2019

In general the args are module specific (wallet, node, gui, chain, mempool, ...) so the args manager should not know about them. This is also in line with how we Setup*Options() for all other modules.

Copy link
Member

@laanwj laanwj Feb 12, 2019

Agree with @MarcoFalke here. It is not the responsibility of ArgsManager to know about or hardcode specific options.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 7, 2019

Concept ACK

@Empact
Copy link
Member

@Empact Empact commented Feb 9, 2019

utACK a99999c

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 12, 2019

utACK a99999c

@laanwj laanwj merged commit a99999c into bitcoin:master Feb 12, 2019
2 checks passed
laanwj added a commit that referenced this issue Feb 12, 2019
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
@MarcoFalke MarcoFalke deleted the Mf1902-Help branch Feb 12, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 21, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#15358 | PR15358]]

Test Plan:
  ninja all check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8013
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 27, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 28, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 29, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 1, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 12, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 12, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 13, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 13, 2021
a99999c util: Add SetupHelpOptions() (MarcoFalke)

Pull request description:

  Every binary we have sets up the help option in their own way and wording.

  Solve that by having one function take care of it for all of them.

Tree-SHA512: 6e947fa8bc2a46fa6ca9f45777020aa269a5df0dd916ebc863224f9a1e0f79e8e7754a1478567307edd9461e8babd77d26bc2710bbd56e8f8da9020aa85a8c9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants