Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Add lock annotation for mapAddressBook #15365

Merged

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 7, 2019

This adds lock annotations for mapAddressBook and also moves one lock from inside GetDestValues to the caller to be in line with the other methods (eraseDestData, addDestData, ...)

@MarcoFalke MarcoFalke force-pushed the Mf1902-LockAnnotmapAddressBook branch from fa2d07e to faa4647 Feb 7, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 7, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14898 (nextpagepointer flag for listtransactions by hosseinamin)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 7, 2019

Concept ACK

@promag
Copy link
Member

@promag promag commented Feb 8, 2019

utACK faa4647.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 8, 2019

utACK faa4647

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Feb 8, 2019
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
@MarcoFalke MarcoFalke merged commit faa4647 into bitcoin:master Feb 8, 2019
2 checks passed
@MarcoFalke MarcoFalke deleted the Mf1902-LockAnnotmapAddressBook branch Feb 8, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 28, 2020
Summary:
bitcoin/bitcoin@faa4647

---

Backport of Core [[bitcoin/bitcoin#15365 | PR15365]]

Test Plan:
  cmake .. -GNinja -DENABLE_SANITIZERS=thread -DENABLE_WERROR=ON

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6282
LarryRuane added a commit to LarryRuane/zcash that referenced this issue May 4, 2021
LarryRuane added a commit to LarryRuane/zcash that referenced this issue Jun 1, 2021
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 27, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 5, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 9, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 10, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 13, 2021
faa4647 wallet: Add lock annotation for mapAddressBook (MarcoFalke)

Pull request description:

  This adds lock annotations for `mapAddressBook` and also moves one lock from inside `GetDestValues` to the caller to be in line with the other methods (`eraseDestData`, `addDestData`, ...)

Tree-SHA512: cef9397523e2f5717d4a9a6b2da1fe07042484a51b3c067ae64425768637f334350a2c3db4ab7e00af99b2a587f6b656b68ee1195f6a3db6d47298d0b2b6174a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants