Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: Remove unused --force option #15370

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@MarcoFalke
Copy link
Member

commented Feb 8, 2019

When someone calls the script they already have all intention to call it, no need to specify a redundant --force.

The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

@MarcoFalke MarcoFalke added the Tests label Feb 8, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Added an unrelated commit for a trivial update of the functional test readme.

@fanquake

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

utACK fae8b8b

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 8, 2019

Merge bitcoin#15370: test_runner: Remove unused --force option
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd

@MarcoFalke MarcoFalke merged commit fae8b8b into bitcoin:master Feb 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-qaWinForce branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.