Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: Remove unused --force option #15370

Merged
merged 2 commits into from Feb 8, 2019

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 8, 2019

When someone calls the script they already have all intention to call it, no need to specify a redundant --force.

The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Feb 8, 2019

Added an unrelated commit for a trivial update of the functional test readme.

@fanquake
Copy link
Member

@fanquake fanquake commented Feb 8, 2019

utACK fae8b8b

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Feb 8, 2019
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
@MarcoFalke MarcoFalke merged commit fae8b8b into bitcoin:master Feb 8, 2019
2 checks passed
@MarcoFalke MarcoFalke deleted the Mf1902-qaWinForce branch Feb 8, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Nov 10, 2020
Summary:
> When someone calls the script they already have all intention to call it, no need to specify a redundant --force.

This is a backport of Core [[bitcoin/bitcoin#15370 | PR15370]]

Test Plan: `ninja && ninja check-functional`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8357
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 27, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 5, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 9, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 10, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 13, 2021
fae8b8b qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d22 test_runner: Remove unused --force option (MarcoFalke)

Pull request description:

  When someone calls the script they already have all intention to call it, no need to specify a redundant `--force`.

  The functional tests are still disabled on the travis windows cross builds, where they'd run into issues when run under Wine.

Tree-SHA512: ada0dd9b3c0cd28c5832a12c5e04c029dc3bfe5ddf366fd0abc24fb7914d2e0f0a873fe756ade7ba780a561abe9bc731838c289accc421deda481269e08514cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants