Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Added missing tests for RPC wallet errors #15378

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Feb 10, 2019

No description provided.

@fanquake fanquake added the Tests label Feb 10, 2019
test/functional/wallet_basic.py Outdated Show resolved Hide resolved
@benthecarman benthecarman force-pushed the tests_missing_tests branch from e658805 to 4d93104 Feb 10, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 10, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #11413 ([wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 10, 2019

Concept ACK

@benthecarman benthecarman force-pushed the tests_missing_tests branch from 4d93104 to 6afdbba Feb 11, 2019
@benthecarman benthecarman force-pushed the tests_missing_tests branch from 6afdbba to dc3b2cc Feb 12, 2019
@promag
Copy link
Member

@promag promag commented Feb 12, 2019

utACK dc3b2cc.


# This will raise an exception for importing an address with the PS2H flag
temp_address = self.nodes[1].getnewaddress()
assert_raises_rpc_error(-5, "Cannot use the p2sh flag with an address - use a script instead", self.nodes[0].importaddress, temp_address, "label", False, True)
Copy link
Member

@MarcoFalke MarcoFalke Feb 12, 2019

nit in the future use named arguments

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 12, 2019

Also reminds me that we shouldn't extend wallet_basic, but rather extend the more specific wallet tests

@MarcoFalke MarcoFalke merged commit dc3b2cc into bitcoin:master Feb 12, 2019
2 checks passed
MarcoFalke added a commit that referenced this issue Feb 12, 2019
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926
@benthecarman benthecarman deleted the tests_missing_tests branch Feb 26, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 1, 2020
Summary: Backport of Core [[ bitcoin/bitcoin#15378 | PR15378 ]]

Test Plan: `ninja && ./test/functional/test_runner.py wallet_basic`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7710
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants