Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Added missing tests for RPC wallet errors #15378

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@benthecarman
Copy link
Contributor

commented Feb 10, 2019

No description provided.

@fanquake fanquake added the Tests label Feb 10, 2019

@benthecarman benthecarman force-pushed the benthecarman:tests_missing_tests branch from e658805 to 4d93104 Feb 10, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #11413 ([wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Concept ACK

@benthecarman benthecarman force-pushed the benthecarman:tests_missing_tests branch from 4d93104 to 6afdbba Feb 11, 2019

@benthecarman benthecarman force-pushed the benthecarman:tests_missing_tests branch from 6afdbba to dc3b2cc Feb 12, 2019

@promag

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

utACK dc3b2cc.


# This will raise an exception for importing an address with the PS2H flag
temp_address = self.nodes[1].getnewaddress()
assert_raises_rpc_error(-5, "Cannot use the p2sh flag with an address - use a script instead", self.nodes[0].importaddress, temp_address, "label", False, True)

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Feb 12, 2019

Member

nit in the future use named arguments

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Also reminds me that we shouldn't extend wallet_basic, but rather extend the more specific wallet tests

@MarcoFalke MarcoFalke merged commit dc3b2cc into bitcoin:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Feb 12, 2019

Merge #15378: tests: Added missing tests for RPC wallet errors
dc3b2cc tests: Added missing tests for RPC wallet errors (Ben Carman)

Pull request description:

Tree-SHA512: b18dcd4f7547c974c93ae67dcd92a168bdb55951b164cf174cb1e59e0daa463187068aec43108309a75d65721a5c0bcdf10a16a9869620f160121e2287559926

@benthecarman benthecarman deleted the benthecarman:tests_missing_tests branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.