Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Makefile.am: add rule for src/bitcoin-wallet #15388

Merged
merged 1 commit into from Feb 14, 2019

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented Feb 12, 2019

Otherwise make src/bitcoin-wallet will fail with No rule to make target.

Also adds bitcoin-wallet.exe to the Windows installer.

@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 12, 2019

I just duplicated everything to make it consistent with make src/bitcoin-tx.

@jnewbery: I think this was missing from #13926

@ken2812221 does the Windows installer bit look OK? @MarcoFalke this probably needs a Gitian build.

Thanks @luke-jr & @laanwj for IRC help.

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 12, 2019

LGTM utACK c9741df

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Feb 12, 2019

utACK c9741df. Thanks @Sjors!

@promag
Copy link
Member

@promag promag commented Feb 12, 2019

Tested ACK c9741df on macOS.

Makefile.am Show resolved Hide resolved
Makefile.am Outdated Show resolved Hide resolved
Makefile.am Outdated Show resolved Hide resolved
@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 13, 2019

Also added to share/setup.nsi.in.

@bitcoin bitcoin deleted a comment from DrahtBot Feb 13, 2019
@Sjors Sjors force-pushed the 2019/02/wallet_tool_make branch from cb870bb to 1852eff Feb 14, 2019
@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 14, 2019

I added 7640765 to see if busting AppVeyor cache (again) can help with breaking builds in master. It's otherwise unrelated to this PR so I can drop the commit or move it to another PR later if needed.

@Sjors Sjors force-pushed the 2019/02/wallet_tool_make branch 2 times, most recently from 7640765 to 1852eff Feb 14, 2019
@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 14, 2019

I moved the AppVeyor commits to a new PR #15405. See also #15407 for a likely solution to the AppVeyor failures.

@Sjors Sjors force-pushed the 2019/02/wallet_tool_make branch from 1852eff to 4a43eb8 Feb 14, 2019
Copy link
Member

@luke-jr luke-jr left a comment

utACK

@MarcoFalke MarcoFalke merged commit 4a43eb8 into bitcoin:master Feb 14, 2019
0 of 2 checks passed
MarcoFalke added a commit that referenced this issue Feb 14, 2019
4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
@Sjors Sjors deleted the 2019/02/wallet_tool_make branch Feb 14, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 14, 2019

Gitian builds for commit 0d1160e (master):

Gitian builds for commit a88d457 (master and this pull):

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Sep 11, 2021
…llet

4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants