Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Makefile.am: add rule for src/bitcoin-wallet #15388

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
7 participants
@Sjors
Copy link
Member

commented Feb 12, 2019

Otherwise make src/bitcoin-wallet will fail with No rule to make target.

Also adds bitcoin-wallet.exe to the Windows installer.

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

I just duplicated everything to make it consistent with make src/bitcoin-tx.

@jnewbery: I think this was missing from #13926

@ken2812221 does the Windows installer bit look OK? @MarcoFalke this probably needs a Gitian build.

Thanks @luke-jr & @laanwj for IRC help.

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

LGTM utACK c9741df

@jnewbery

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

utACK c9741df. Thanks @Sjors!

@promag

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Tested ACK c9741df on macOS.

Show resolved Hide resolved Makefile.am
Show resolved Hide resolved Makefile.am Outdated
Show resolved Hide resolved Makefile.am Outdated

@Sjors Sjors force-pushed the Sjors:2019/02/wallet_tool_make branch from c9741df to cb870bb Feb 13, 2019

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

Also added to share/setup.nsi.in.

@bitcoin bitcoin deleted a comment from DrahtBot Feb 13, 2019

@Sjors Sjors force-pushed the Sjors:2019/02/wallet_tool_make branch from cb870bb to 1852eff Feb 14, 2019

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

I added 7640765 to see if busting AppVeyor cache (again) can help with breaking builds in master. It's otherwise unrelated to this PR so I can drop the commit or move it to another PR later if needed.

@Sjors Sjors force-pushed the Sjors:2019/02/wallet_tool_make branch 2 times, most recently from 7640765 to 1852eff Feb 14, 2019

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

I moved the AppVeyor commits to a new PR #15405. See also #15407 for a likely solution to the AppVeyor failures.

@Sjors Sjors force-pushed the Sjors:2019/02/wallet_tool_make branch from 1852eff to 4a43eb8 Feb 14, 2019

@luke-jr
Copy link
Member

left a comment

utACK

@MarcoFalke MarcoFalke merged commit 4a43eb8 into bitcoin:master Feb 14, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

MarcoFalke added a commit that referenced this pull request Feb 14, 2019

Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet
4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)

Pull request description:

  Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`.

  Also adds `bitcoin-wallet.exe` to the Windows installer.

Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681

@Sjors Sjors deleted the Sjors:2019/02/wallet_tool_make branch Feb 14, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

Gitian builds for commit 0d1160e (master):

Gitian builds for commit a88d457 (master and this pull):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.