Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc: add rapidcheck property tests #15398

Merged
merged 1 commit into from Feb 17, 2019
Merged

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Feb 13, 2019

This PR add the property tests into the binaries built by MSVC.

And another trivial change is that I reordered the appveyor package list.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 13, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15382 ([util] add runCommandParseJSON by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@sipsorcery
Copy link
Member

@sipsorcery sipsorcery commented Feb 16, 2019

tACK d067e81.

Appveyor build now runs these two additional tests:

rpc_deriveaddresses.py | ✓ Passed | 2 s
rpc_deriveaddresses.py --usecli | ✓ Passed | 2 s

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 16, 2019

utACK d067e81

@fanquake fanquake changed the title msvc: add rapid check property tests msvc: add rapidcheck property tests Feb 17, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Feb 17, 2019

utACK d067e81

@laanwj laanwj merged commit d067e81 into bitcoin:master Feb 17, 2019
2 checks passed
laanwj added a commit that referenced this issue Feb 17, 2019
d067e81 msvc: add rapid check property tests (Chun Kuan Lee)

Pull request description:

  This PR add the property tests into the binaries built by MSVC.

  And another trivial change is that I reordered the appveyor package list.

Tree-SHA512: 25d66db464beb7b512cc1f88d8557d6a047000a97d78f49884bb91a65ec142e0458039c919f51bf73413359fcf3e63e1ea4d76586b862f1c140d2ca05ee8b23d
@ken2812221 ken2812221 deleted the appveyor-rapid-check branch Feb 17, 2019
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Sep 16, 2021
d067e81 msvc: add rapid check property tests (Chun Kuan Lee)

Pull request description:

  This PR add the property tests into the binaries built by MSVC.

  And another trivial change is that I reordered the appveyor package list.

Tree-SHA512: 25d66db464beb7b512cc1f88d8557d6a047000a97d78f49884bb91a65ec142e0458039c919f51bf73413359fcf3e63e1ea4d76586b862f1c140d2ca05ee8b23d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants