Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Script validation flags #15399

Merged
merged 2 commits into from Feb 15, 2019
Merged

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 13, 2019

No description provided.

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 13, 2019

Code review utACK fab15ff
Haven't tried what code paths are reached in a fuzzer.

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Feb 13, 2019

Great! Thanks for looking at this. If you find new coverage, don't forget to add them to https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus/script_flags, such that progress is accumulative over all machines that run the fuzzer and new fuzzers don't have to start from zero.

Related: #15295 (comes with instructions on how to build the fuzzer)

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 14, 2019

Strong concept ACK

Thanks for adding more fuzzing targets! Very much needed!

unsigned int fuzzed_flags;
ds >> fuzzed_flags;

for (unsigned i = 0; i < tx.vin.size(); ++i) {
Copy link
Contributor

@practicalswift practicalswift Feb 14, 2019

The dropped int here intentional? Same result but looks non-idiomatic :-)

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Feb 15, 2019
fab15ff fuzz: Script validation flags (MarcoFalke)
fabcfa5 fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (MarcoFalke)

Pull request description:

Tree-SHA512: 83c0cfeae0771b7ffe14e6b0eaeda06602b91f5bf4aa2f54fd4f7ef2350299679fd2d9339b02e43309bfddccc01d3aef25ce1a3d2c4f9b54f26e16e1249e05db
@MarcoFalke MarcoFalke merged commit fab15ff into bitcoin:master Feb 15, 2019
2 checks passed
@jamesob
Copy link
Member

@jamesob jamesob commented Feb 15, 2019

Post-merge utACK fab15ff

Nice!

@MarcoFalke MarcoFalke deleted the Mf1902-fuzzSoft branch Feb 15, 2019
random-zebra added a commit to PIVX-Project/PIVX that referenced this issue May 28, 2021
d059544 [Build] fuzz target, change LIBBITCOIN_ZEROCOIN link order. (furszy)
2396e6b [fuzz] Add ContextualCheckTransaction call to transaction target. (furszy)
f0887a0 Fuzzing documentation "PIVX-fication" (furszy)
9631f46 [doc] add sanitizers documentation in developer-notes.md (furszy)
70a0ace tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. Avoid code repetition. (practicalswift)
e1b92b6 ignore new fuzz targets gitignore (furszy)
d058d8c tests: Add deserialization fuzzing harnesses (furszy)
e1f666c tests: Remove TRANSACTION_DESERIALIZE (replaced by transaction fuzzer) (practicalswift)
b5f291c tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions (furszy)
3205871 fuzz: Remove option --export_coverage from test_runner (MarcoFalke)
52693ee fuzz: Add option to merge input dir to test runner (MarcoFalke)
2b4f8aa doc: Remove --disable-ccache from docs (MarcoFalke)
b54b1d6 tests: Improve test runner output in case of target errors (practicalswift)
cd6134f test: Log output even if fuzzer failed (MarcoFalke)
48cd0c8 doc: Improve fuzzing docs for macOS users (Fabian Jahr)
d642b67 [Build] Do not disable wallet when fuzz is enabled. (furszy)
c3447b5 Update doc and CI config (qmma)
1266d3e Disable other targets when enable-fuzz is set (qmma)
f28ac9a build: Allow to configure --with-sanitizers=fuzzer (MarcoFalke)
425742c fuzz: test_runner: Better error message when built with afl (MarcoFalke)
541f442 qa: Add test/fuzz/test_runner.py (MarcoFalke)
89fe5b2 Add missing LIBBITCOIN_ZMQ to test target (furszy)
58dbe79 add fuzzing binaries to gitignore. (furszy)
393a126 fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (MarcoFalke)
a568df5 test: Build fuzz targets into separate executables (furszy)
d5dddde [test] fuzz: make test_one_input return void (MarcoFalke)
2e4ec58 [fuzzing] initialize chain params by default. (furszy)
08d8ebe [tests] Add libFuzzer support. (practicalswift)
84f72da [test] Speed up fuzzing by ~200x when using afl-fuzz (practicalswift)
faf2be6 Init ECC context for test_bitcoin_fuzzy. (Gregory Maxwell)
11150df Make fuzzer actually test CTxOutCompressor (Pieter Wuille)
d6f6a85 doc: Add bare-bones documentation for fuzzing (Wladimir J. van der Laan)
5c3b550 Simple fuzzing framework (pstratem)

Pull request description:

  As the title says, adding fuzzing framework support so we can start getting serious on this area as well.

  Adapted the following PRs:

  * bitcoin#9172.
  * bitcoin#9354.
  * bitcoin#9691.
  * bitcoin#10415.
  * bitcoin#10440.
  * bitcoin#15043.
  * bitcoin#15047.
  * bitcoin#15295.
  * bitcoin#15399 (fabcfa5 only).
  * bitcoin#16338.
  * bitcoin#17051.
  * bitcoin#17076.
  * bitcoin#17225.
  * bitcoin#17942.
  * bitcoin#16236 (only fa35c42).
  * bitcoin#18166 (only f2472f6).
  * bitcoin#18300.
  * And.. probably will go further and continue adapting more PRs..

ACKs for top commit:
  random-zebra:
    utACK d059544 and merging...

Tree-SHA512: c0b05bca47bf99bafd8abf1453c5636fe05df75f16d0e9c750368ea2aed8142f0b28d28af1d23468b8829188412a80fd3b7bdbbda294b940d78aec80c1c7d03a
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Aug 2, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Aug 5, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Aug 5, 2021
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Aug 6, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Aug 8, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Aug 11, 2021
5tefan added a commit to 5tefan/dash that referenced this issue Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants