Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Script validation flags #15399

Merged
merged 2 commits into from Feb 15, 2019

Conversation

Projects
None yet
4 participants
@MarcoFalke
Copy link
Member

commented Feb 13, 2019

No description provided.

@MarcoFalke MarcoFalke added the Tests label Feb 13, 2019

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1902-fuzzSoft branch from fa2f07a to fab15ff Feb 13, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Code review utACK fab15ff
Haven't tried what code paths are reached in a fuzzer.

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

Great! Thanks for looking at this. If you find new coverage, don't forget to add them to https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus/script_flags, such that progress is accumulative over all machines that run the fuzzer and new fuzzers don't have to start from zero.

Related: #15295 (comes with instructions on how to build the fuzzer)

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Strong concept ACK

Thanks for adding more fuzzing targets! Very much needed!

unsigned int fuzzed_flags;
ds >> fuzzed_flags;

for (unsigned i = 0; i < tx.vin.size(); ++i) {

This comment has been minimized.

Copy link
@practicalswift

practicalswift Feb 14, 2019

Member

The dropped int here intentional? Same result but looks non-idiomatic :-)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 15, 2019

Merge bitcoin#15399: fuzz: Script validation flags
fab15ff fuzz: Script validation flags (MarcoFalke)
fabcfa5 fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (MarcoFalke)

Pull request description:

Tree-SHA512: 83c0cfeae0771b7ffe14e6b0eaeda06602b91f5bf4aa2f54fd4f7ef2350299679fd2d9339b02e43309bfddccc01d3aef25ce1a3d2c4f9b54f26e16e1249e05db

@MarcoFalke MarcoFalke merged commit fab15ff into bitcoin:master Feb 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamesob

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Post-merge utACK fab15ff

Nice!

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-fuzzSoft branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.