Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] AppVeyor: clean cache when build configuration changes #15405

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented Feb 14, 2019

AppVeyor builds started starting failing on master after I cleaned the cache in #15382. In addition, it appeared that a new dependency (boost-process) wasn't getting added in that PR without at least cleaning the vcpkg cache.

@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 14, 2019

In general it seems unhealthy that independent PRs can mess with AppVeyor cache. Not sure how Travis handles that; maybe cache can be made read-only for PR's and only allow master to write to it?

cc @ken2812221

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Feb 14, 2019

This is due to a merge conflict between #13926 and #14372. See #15407

@Sjors
Copy link
Member Author

@Sjors Sjors commented Feb 14, 2019

@ken2812221 thanks! Let's see if your PR makes the error go away.

Do you think the cache rules in this PR make sense?

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Feb 14, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@MarcoFalke MarcoFalke closed this Feb 14, 2019
@MarcoFalke MarcoFalke reopened this Feb 14, 2019
@Sjors Sjors force-pushed the 2019/02/appveyor_cache branch from 9710632 to 88a91e2 Feb 14, 2019
@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Feb 15, 2019

utACK 88a91e2

@MarcoFalke MarcoFalke merged commit 88a91e2 into bitcoin:master Feb 15, 2019
1 of 2 checks passed
MarcoFalke added a commit that referenced this issue Feb 15, 2019
…changes

88a91e2 [build] AppVeyor: clean cache when build configuration changes (Sjors Provoost)

Pull request description:

  AppVeyor builds started starting failing on master after I cleaned the cache in #15382. In addition, it appeared that a new dependency (boost-process) wasn't getting added in that PR without at least cleaning the vcpkg cache.

Tree-SHA512: 1ad87bf6ca866cc20db04682cdf7572b59d22a7eaf346f390fc476c5e28bc5422733277fd765e5c9fd2ea88107b52fccd13f1f7e55493f567c4c4a1c16d7cb3a
@Sjors Sjors deleted the 2019/02/appveyor_cache branch Feb 15, 2019
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Sep 16, 2021
…ration changes

88a91e2 [build] AppVeyor: clean cache when build configuration changes (Sjors Provoost)

Pull request description:

  AppVeyor builds started starting failing on master after I cleaned the cache in bitcoin#15382. In addition, it appeared that a new dependency (boost-process) wasn't getting added in that PR without at least cleaning the vcpkg cache.

Tree-SHA512: 1ad87bf6ca866cc20db04682cdf7572b59d22a7eaf346f390fc476c5e28bc5422733277fd765e5c9fd2ea88107b52fccd13f1f7e55493f567c4c4a1c16d7cb3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants