Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: txindex: interrupt threadGroup before calling destructor #15410

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
3 participants
@MarcoFalke
Copy link
Member

commented Feb 14, 2019

Fixes the data races with the tread sanitizer such as

@MarcoFalke MarcoFalke added the Tests label Feb 14, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

@sipa You can probably remove the top commit in #15402 (comment)

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 14, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14111 (index: Create IndexRunner class for activing indexes. by jimpo)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@promag

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

utACK fab6b07.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 16, 2019

Merge bitcoin#15410: test: txindex: interrupt threadGroup before call…
…ing destructor

fab6b07 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)

Pull request description:

  Fixes the data races with the tread sanitizer such as

  * https://travis-ci.org/MarcoFalke/bitcoin/jobs/492330554
  * bitcoin#15402 (comment)
  * ...

Tree-SHA512: 40608c70d92a1dd68efc1d41eecc8e2fb7738508e21f91f0ad353adcceed60fa624f15bf72a5b69a9444157b261183abbe9fc4cc5dd8aebc1c49506b239e8e88

@MarcoFalke MarcoFalke merged commit fab6b07 into bitcoin:master Feb 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-testIndexInterr branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.