Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree #15413

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 15, 2019

Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.

This is a subset of #15192: split up requested by MarcoFalke in #15192 (comment).

The end goal is to get the corresponding GUARDED_BY(...):s in (see #15192).

@fanquake fanquake added the Tests label Feb 15, 2019
@MarcoFalke MarcoFalke merged commit 543ef7d into bitcoin:master Feb 15, 2019
1 of 2 checks passed
MarcoFalke added a commit that referenced this issue Feb 15, 2019
…g pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of #15192: split up requested by MarcoFalke in #15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see #15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
deadalnix added a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Apr 27, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#13219 | PR13219]] and [[bitcoin/bitcoin#13806 | PR13806]] . Due to many backport being done out of oder or improperly, this contains elements of [[bitcoin/bitcoin#15413 | PR15413]] and [[bitcoin/bitcoin#15788 | PR15788]]

Test Plan:
  make check
  ./src/bench/bench_bitcoin

Check that the new benchmark is run.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5848
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Aug 17, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#13219 | PR13219]] and [[bitcoin/bitcoin#13806 | PR13806]] . Due to many backport being done out of oder or improperly, this contains elements of [[bitcoin/bitcoin#15413 | PR15413]] and [[bitcoin/bitcoin#15788 | PR15788]]

Test Plan:
  make check
  ./src/bench/bench_bitcoin

Check that the new benchmark is run.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5848
@practicalswift practicalswift deleted the validation-cs_main-tests branch Apr 10, 2021
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 5, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 7, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 9, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 10, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 13, 2021
…ccessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 13, 2021
…d when accessing pcoinsdbview, pcoinsTip or pblocktree

543ef7d tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)

Pull request description:

  Add missing `cs_main` locks required when accessing `pcoinsdbview`, `pcoinsTip` or `pblocktree`.

  This is a subset of bitcoin#15192: split up requested by MarcoFalke in bitcoin#15192 (comment).

  The end goal is to get the corresponding `GUARDED_BY(...)`:s in (see bitcoin#15192).

Tree-SHA512: 0eb1987dba1a2f1faf0910c421f6d90a20b8a253486eb3301d5bca66d128b19120664e3a8580bdce7b428df817284faf94243250bf561f91d2d31a52d134aa67
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Oct 12, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Oct 12, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Oct 12, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants