Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code #15428

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
3 participants
@luke-jr
Copy link
Member

commented Feb 17, 2019

This is intended to be merged only once the node can reliably provide a Tor hidden service for inbound connections.

It adds a "Pairing" tab to the GUI, which displays the onion address as copyable text, and a QR code (for scanning by mobile wallets).

TODO: Probably a BIP should be written for the bitcoin-p2p: URI scheme added here, and pairing behaviours.
20190502-Knots-Pairing

@luke-jr luke-jr force-pushed the luke-jr:tor_gui_pairing branch from 7203344 to bd4b911 Feb 17, 2019

@fanquake fanquake added the GUI label Feb 17, 2019

@luke-jr luke-jr force-pushed the luke-jr:tor_gui_pairing branch from bd4b911 to 9a3d852 Feb 17, 2019


public:
explicit PairingPage(QWidget *parent = nullptr);
~PairingPage() {};

This comment has been minimized.

Copy link
@practicalswift

practicalswift Feb 25, 2019

Member

Nit: Accidental semicolon.

@@ -37,6 +39,64 @@ QRImageWidget::QRImageWidget(QWidget *parent):
contextMenu->addAction(copyImageAction);
}

bool QRImageWidget::setQR(const QString& data, const QString& text)

This comment has been minimized.

Copy link
@practicalswift

practicalswift Feb 25, 2019

Member

data here shadows a member variable?

@luke-jr luke-jr changed the title GUI: Add Pairing tab with Tor onion address as copyable text and QR code [WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code Feb 28, 2019

@luke-jr

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

I think I need to rewrite this to work sanely with no-wallet builds. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.