Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 #15429

Merged
merged 1 commit into from Feb 18, 2019
Merged

Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 #15429

merged 1 commit into from Feb 18, 2019

Conversation

@gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Feb 17, 2019

m_assumed_blockchain_size/m_assumed_chain_state_size were still accurate.

…63378.

m_assumed_blockchain_size/m_assumed_chain_state_size were still accurate.
@fanquake fanquake added this to the 0.18.0 milestone Feb 17, 2019
@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 17, 2019

utACK a083f75

Loading

@fanquake
Copy link
Member

@fanquake fanquake commented Feb 17, 2019

tACK a083f75

bitcoin-cli getchaintxstats 4096 0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee

{
  "time": 1550374134, // matches 👍 
  "txcount": 383732546, // matches 👍 
  "window_final_block_hash": "0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee",
  "window_block_count": 4096,
  "window_tx_count": 8872107,
  "window_interval": 2407303,
  "txrate": 3.685496590998308 // matches 👍 
}

bitcoin-cli getblock 0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee

 "height": 563378,
<.. snip ..>
 "time": 1550374134,
  "mediantime": 1550373349,
  "nonce": 3355453177,
  "bits": "172e6f88",
  "difficulty": 6061518831027.271,
  // matches 👍 
  "chainwork": "0000000000000000000000000000000000000000051dc8b82f450202ecb3d471",
  "nTx": 359,
  "previousblockhash": "00000000000000000001827a07f51769246d852e63c413bc2cd5caa104970f3f",
  "nextblockhash": "0000000000000000001d6cf3d8d1bf2e0b1883f6684bb2dddcb57a5d4c81ec7f"

Relevant IRC chat (line 120):

120 2019-02-17T03:42:58 bitcoin-git: [bitcoin] gmaxwell opened pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) #15429
122 2019-02-17T03:43:04 gmaxwell: sipa: as requested, #15429 you might want to 0.18 tag.
123 2019-02-17T03:45:31 echeveria: gmaxwell: isn't the block hash usually set back a bit from the tip?
124 2019-02-17T03:45:45 echeveria: the one in the pull request is approximately now.
125 2019-02-17T03:48:59 fanquake: by the time that PR gets merged, and then 0.18.0 released, it should be back from the tip. testnet is usually set back a larger amount.
126 2019-02-17T03:49:57 echeveria: right, sure
129 2019-02-17T04:03:11 gmaxwell: echeveria: it will be by the time it gets merged.
130 2019-02-17T04:04:04 gmaxwell: IIRC the first time I did it I set it further back, but then noticed how long it took to get merged, since then I've set it right at the tip after first looking to see if I could find a competing block

Loading

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 18, 2019

utACK a083f75, thanks

Loading

@laanwj laanwj merged commit a083f75 into bitcoin:master Feb 18, 2019
2 checks passed
Loading
laanwj added a commit that referenced this issue Feb 18, 2019
…ts to height 563378

a083f75 Update assumevalid, minimumchainwork, and getchaintxstats to height 563378. (Gregory Maxwell)

Pull request description:

  m_assumed_blockchain_size/m_assumed_chain_state_size were still accurate.

Tree-SHA512: 9b08a5d6023c0e24ab3d8c43c0978181eb853f15c4db9bc69e72efc94c89600780bc73d9f46dbaf5241d28b135546dd30e7abd50a89096b5fd3f7252308491cc
@jnewbery
Copy link
Member

@jnewbery jnewbery commented Feb 19, 2019

ACK a083f75 . Matches output on my node.

Loading

@moneyball
Copy link
Contributor

@moneyball moneyball commented Feb 21, 2019

ACK a083f75 . Matches output on my node as well. I ran the commands that @fanquake posted above and verified those #s matched what is in the commit. I'm not familiar enough with the system to ensure anything else needs to be verified but at least these numbers match.

Loading

@jamesob jamesob mentioned this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants