Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Use fsbridge::ifstream to fix Windows path issue #15468

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Feb 23, 2019

Fix #15460

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2019

image

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 24, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

utACK 6ad79cb

@ryanofsky
Copy link
Contributor

left a comment

utACK 6ad79cb. I was going to suggest that maybe there should be a linter only allowing use of fsbridge::ifstream, and not other ifstream classes. But this might be too strict because in a lot of cases we can know that filename being opened is ascii.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

Gitian builds for commit b4fc525 (master):

Gitian builds for commit fef7c84 (master and this pull):

@fanquake

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

utACK 6ad79cb

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

I was going to suggest that maybe there should be a linter only allowing use of fsbridge::ifstream, and not other ifstream classes.

File system access should always go through the fsbridge when possible, this is better for sandboxing. So I think this would be appropriate, as well as mentioning this in the developer notes of course.
(but not in this PR)

@laanwj laanwj merged commit 6ad79cb into bitcoin:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 27, 2019

Merge #15468: wallet: Use fsbridge::ifstream to fix Windows path issue
6ad79cb wallet: Use fsbridge::ifstream to fix Windows path issue (Chun Kuan Lee)

Pull request description:

  Fix #15460

Tree-SHA512: 1dab04184608543d49c86cbcfb679d63d35cb7bf3bde2e2d9ddf25ec8977de42b7131db5e81a305f3452858079dbcf68f6ad4624c89575d3d7e5b550687fc6ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.