Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove misleading hint in getrawtransaction #15477

Merged
merged 2 commits into from Feb 27, 2019

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 25, 2019

For 0.18.0

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

@MarcoFalke MarcoFalke force-pushed the Mf1902-rpcRawDocFix branch from fa4f4a0 to 9999879 Feb 26, 2019
@Sjors
Copy link
Member

@Sjors Sjors commented Feb 26, 2019

(nvm my previous comment, my working tree wasn't clean)

tACK 9999879

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 27, 2019

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

So should it?

@promag
Copy link
Member

@promag promag commented Feb 27, 2019

ACK 9999879.

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

So should it?

By adding an option? Anyway, that is the goal of:

getrawtransaction "txid" ( verbose "blockhash" )

Return the raw transaction data.

By default this function only works for mempool transactions...

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 27, 2019

By adding a option? Anyway, that is the goal of:

If there's another documented way to do it that's good enough.

utACK 9999879

@laanwj laanwj merged commit 9999879 into bitcoin:master Feb 27, 2019
2 checks passed
laanwj added a commit that referenced this issue Feb 27, 2019
9999879 refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction (MarcoFalke)
fa9ff8f doc: Remove misleading hint in getrawtransaction (MarcoFalke)

Pull request description:

  For 0.18.0

  I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

Tree-SHA512: 7ac85500c8192314347b7283cd369196bb959c124863642b6c1ce73d5662b1cbe4f42ded9c374dac6657458ab70b01810caf1235dd1d2b404bf376ebf09efa69
@MarcoFalke MarcoFalke deleted the Mf1902-rpcRawDocFix branch Feb 27, 2019
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 8, 2021
9999879 refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction (MarcoFalke)
fa9ff8f doc: Remove misleading hint in getrawtransaction (MarcoFalke)

Pull request description:

  For 0.18.0

  I asked this line to be added in bitcoin#15159, which was wrong because getmempoolentry does not return the raw transaction hex.

Tree-SHA512: 7ac85500c8192314347b7283cd369196bb959c124863642b6c1ce73d5662b1cbe4f42ded9c374dac6657458ab70b01810caf1235dd1d2b404bf376ebf09efa69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants