Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove misleading hint in getrawtransaction #15477

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
4 participants
@MarcoFalke
Copy link
Member

commented Feb 25, 2019

For 0.18.0

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Feb 25, 2019

MarcoFalke added some commits Feb 26, 2019

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1902-rpcRawDocFix branch from fa4f4a0 to 9999879 Feb 26, 2019

@Sjors

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

(nvm my previous comment, my working tree wasn't clean)

tACK 9999879

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

So should it?

@promag

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

ACK 9999879.

I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

So should it?

By adding an option? Anyway, that is the goal of:

getrawtransaction "txid" ( verbose "blockhash" )

Return the raw transaction data.

By default this function only works for mempool transactions...
@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

By adding a option? Anyway, that is the goal of:

If there's another documented way to do it that's good enough.

utACK 9999879

@laanwj laanwj merged commit 9999879 into bitcoin:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 27, 2019

Merge #15477: doc: Remove misleading hint in getrawtransaction
9999879 refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction (MarcoFalke)
fa9ff8f doc: Remove misleading hint in getrawtransaction (MarcoFalke)

Pull request description:

  For 0.18.0

  I asked this line to be added in #15159, which was wrong because getmempoolentry does not return the raw transaction hex.

Tree-SHA512: 7ac85500c8192314347b7283cd369196bb959c124863642b6c1ce73d5662b1cbe4f42ded9c374dac6657458ab70b01810caf1235dd1d2b404bf376ebf09efa69

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1902-rpcRawDocFix branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.