Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc: Use a single file to specify the include path #15503

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@ken2812221
Copy link
Member

commented Feb 28, 2019

Specify the include files in 1 line and 1 file instead of 64 lines and 16 files.

Also, this could avoid MSVC and autoconf include path inconsistency.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

utACK 4a5e52c

-63 lines of code -- nice!

pull bot pushed a commit to jaschadub/bitcoin that referenced this pull request Feb 28, 2019

Merge bitcoin#15503: msvc: Use a single file to specify the include path
4a5e52c msvc: Use a single file to specify the include path (Chun Kuan Lee)

Pull request description:

  Specify the include files in 1 line and 1 file instead of 64 lines and 16 files.

  Also, this could avoid MSVC and autoconf include path inconsistency.

Tree-SHA512: e2e283913d8118d70fd94b0fb42c3b629b0d9d94aa08a4f625945992fda830c94ecdde8dc7647e28c4f35f8466de3b38cfd7ed7ca78d611612b3b49784fa3745

@MarcoFalke MarcoFalke merged commit 4a5e52c into bitcoin:master Feb 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ken2812221 ken2812221 deleted the ken2812221:msvc-include-fix branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.