Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Rename size to vsize in mempool related calls #15637

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
5 participants
@fanquake
Copy link
Member

fanquake commented Mar 22, 2019

#13008 rebased on master, with release notes split out.

In getmempoolancestors, getmempooldescendants, getmempoolentry and getrawmempool RPCs size returns the virtual transaction size as defined in BIP 141. Renaming it to vsize makes it consistent with returned value and other calls such as getrawtransaction.

Related to #11218.

@fanquake fanquake requested review from jnewbery and MarcoFalke Mar 22, 2019

@fanquake fanquake force-pushed the fanquake:rebased-13008-rename-size-vsize branch from 14f98c5 to e26f455 Mar 22, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Mar 22, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14649 (RPC: add weight to mempool entry output by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Mar 23, 2019

utACK e26f455

@MarcoFalke MarcoFalke added this to the 0.19.0 milestone Mar 23, 2019

Show resolved Hide resolved src/rpc/blockchain.cpp Outdated

@fanquake fanquake force-pushed the fanquake:rebased-13008-rename-size-vsize branch from e26f455 to e16b6a7 Mar 24, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Mar 25, 2019

re-utACK e16b6a7

Only change is to fixup the deprecation notice with the right version

@jnewbery

This comment has been minimized.

Copy link
Member

jnewbery commented Mar 26, 2019

utACK e16b6a7

Thanks!

@MarcoFalke MarcoFalke merged commit e16b6a7 into bitcoin:master Mar 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Mar 26, 2019

Merge #15637: rpc: Rename size to vsize in mempool related calls
e16b6a7 rpc: Rename size to vsize in mempool related calls (Miguel Herranz)

Pull request description:

  #13008 rebased on `master`, with release notes split out.

  > In getmempoolancestors, getmempooldescendants, getmempoolentry and getrawmempool RPCs size returns the virtual transaction size as defined in BIP 141. Renaming it to vsize makes it consistent with returned value and other calls such as getrawtransaction.
  >
  > Related to #11218.

ACKs for commit e16b6a:
  MarcoFalke:
    re-utACK e16b6a7
  jnewbery:
    utACK e16b6a7

Tree-SHA512: ce95260fe7f280eacf4ff70bfffe02315c3a521b3b462a34e72a05b90733f40cc473319ac2df05d3e3c12cb7b1fbf2a1bbea632a8f979fff94207854cdbd494d

romanz added a commit to romanz/electrs that referenced this pull request Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.