Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Win32 defines to configure.ac to ensure they are globally defined #15704

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@luke-jr
Copy link
Member

commented Mar 30, 2019

#9245 no longer needs this, since the main _WIN32_WINNT got bumped by something else.

So rather than just lose it, might as well get it merged in independently.

I'm not aware of any practical effects, but it seems safer to use the same API versions everywhere.

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

I think this needs analogous MSVC build system changes.

@luke-jr luke-jr force-pushed the luke-jr:win32_defines_globally branch from 033ddef to e38c194 Mar 30, 2019

@luke-jr

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

Fixed

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15529 (Add Qt programs to msvc build by sipsorcery)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke MarcoFalke changed the title Move Win32 defines to configure.ac to ensure they are globally defined build: Move Win32 defines to configure.ac to ensure they are globally defined Mar 30, 2019

@MarcoFalke MarcoFalke changed the title build: Move Win32 defines to configure.ac to ensure they are globally defined Move Win32 defines to configure.ac to ensure they are globally defined Mar 30, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

Gitian builds for commit 79c345a (master):

Gitian builds for commit 4a0c046 (master and this pull):

@sipsorcery

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

tACK e38c194 with msvc x64.

(haven't tested the mingw build)

@practicalswift

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

FWIW: I've verified that a disassembly of the bitcoind binary built on a Ubuntu 18.04 machine with this patch applied is identical to a disassembly of the bitcoind binary built against master (as expected).

@fanquake fanquake requested a review from ken2812221 Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.