Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Generate bech32 addresses by default #15711

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@MarcoFalke
Copy link
Member

MarcoFalke commented Mar 31, 2019

Most services support bech32 addresses now, so generating legacy addresses by default seems overly cautious. bech32 addresses are more robust and user friendly in multiple ways.

@promag

This comment has been minimized.

Copy link
Member

promag commented Apr 1, 2019

utACK faf62d9, maybe add a release note "checkbox changed, but the behavior/outcome remains the same".

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

MarcoFalke commented Apr 1, 2019

Good point, but I think for the GUI it is self-explanatory, since the button comes with a help text and a massive tooltip

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 2, 2019

utACK faf62d9, don't think a release note is needed for this specifically, though a general release note on switching to bech32 by default would make sense

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Apr 3, 2019

tACK faf62d9

bech32

legacy

@MarcoFalke MarcoFalke added this to the 0.19.0 milestone Apr 4, 2019
@MarcoFalke

This comment has been minimized.

Copy link
Member Author

MarcoFalke commented Apr 4, 2019

This will be merged next Monday unless there are objections

@Empact

This comment has been minimized.

Copy link
Member

Empact commented Apr 5, 2019

utACK faf62d9

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Apr 8, 2019
faf62d9 gui: Generate bech32 addresses by default (MarcoFalke)

Pull request description:

  Most services support bech32 addresses now, so generating legacy addresses by default seems overly cautious. bech32 addresses are more robust and user friendly in multiple ways.

ACKs for commit faf62d:
  promag:
    utACK faf62d9, maybe add a release note "checkbox changed, but the behavior/outcome remains the same".
  laanwj:
    utACK faf62d9, don't think a release note is needed for this specifically, though a general release note on switching to bech32 by default would make sense
  fanquake:
    tACK faf62d9
  Empact:
    utACK bitcoin@faf62d9

Tree-SHA512: a03e6ccf1e5476fe800941992c531664830cec0644984d8bce97c8d8f5d6d9abd528ab979892368cd195e7c8b9083d6b8dfd36a7cb172aa9dbeaa01a948e30e1
@MarcoFalke MarcoFalke merged commit faf62d9 into bitcoin:master Apr 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarcoFalke MarcoFalke deleted the MarcoFalke:1904-guiBech32 branch Apr 8, 2019
@MarkLTZ MarkLTZ mentioned this pull request May 31, 2019
44 of 244 tasks complete
fanquake added a commit that referenced this pull request Aug 6, 2019
fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke)

Pull request description:

  This commit was missing from my previous pull request for some reason 🤔 :

  *    gui: Generate bech32 addresses by default #15711

ACKs for top commit:
  jonasschnelli:
    Tested ACK fa5a4cd
  promag:
    ACK fa5a4cd.
  fanquake:
    ACK fa5a4cd

Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
sidhujag added a commit to syscoin/syscoin that referenced this pull request Aug 10, 2019
…2, fixup)

fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke)

Pull request description:

  This commit was missing from my previous pull request for some reason 🤔 :

  *    gui: Generate bech32 addresses by default bitcoin#15711

ACKs for top commit:
  jonasschnelli:
    Tested ACK fa5a4cd
  promag:
    ACK fa5a4cd.
  fanquake:
    ACK fa5a4cd

Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.